-
Notifications
You must be signed in to change notification settings - Fork 308
refactor: use t.TempDir() instead of os.MkdirTemp #1059
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: yuhangcangqian <[email protected]>
WalkthroughThe pull request simplifies temporary directory creation in the test file by replacing the manual Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (1.64.8)Error: you are using a configuration file for golangci-lint v2 with golangci-lint v1: please use golangci-lint v2 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
@Mergifyio backport release/v1.2.x |
@Mergifyio backport release/v1.3.x |
✅ Backports have been created
|
✅ Backports have been created
|
Signed-off-by: yuhangcangqian <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]> (cherry picked from commit af0fed2)
Signed-off-by: yuhangcangqian <[email protected]> Co-authored-by: Alex | Interchain Labs <[email protected]> (cherry picked from commit af0fed2)
…1076) Co-authored-by: yuhangcangqian <[email protected]>
…1077) Co-authored-by: yuhangcangqian <[email protected]>
TempDir returns a temporary directory for the test to use.The directory is automatically removed when the test and
all its subtests complete. More info https://pkg.go.dev/testing#B.TempDir
Summary by CodeRabbit