fix(rpc): use ResettingTimer for RPC duration metrics#12
Closed
danbryan wants to merge 1 commit intorelease/1.16from
Closed
fix(rpc): use ResettingTimer for RPC duration metrics#12danbryan wants to merge 1 commit intorelease/1.16from
danbryan wants to merge 1 commit intorelease/1.16from
Conversation
The rpc/duration/all metric was using metrics.NewRegisteredTimer which accumulates samples over the entire process lifetime. When exported to Prometheus, quantile values grow to millions of seconds (displayed as years). Switch to NewRegisteredResettingTimer which resets its sample buffer on each Prometheus scrape, ensuring quantile calculations use recent data only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rpc/duration/all metric was using metrics.NewRegisteredTimer which accumulates samples over the entire process lifetime. When exported to Prometheus, quantile values grow to millions of seconds (displayed as years).
Switch to NewRegisteredResettingTimer which resets its sample buffer on each Prometheus scrape, ensuring quantile calculations use recent data only.