Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sims): Add simsx support to modules #24145

Draft
wants to merge 4 commits into
base: release/v0.53.x
Choose a base branch
from

Conversation

alpe
Copy link
Contributor

@alpe alpe commented Mar 26, 2025

🚧 WIP - early version

Description

After #24126
Closes: #XXXX

Note:
evidence, feegrant and nft are not proper setup in simapp for sims. They still run an old version. Updating go.mod causes conflicts


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@alpe alpe force-pushed the alex/23762_simsx_4 branch from 8748d09 to 1d535e9 Compare March 27, 2025 08:10
@alpe alpe force-pushed the alex/23762_simsx_4 branch from 7c46764 to c80c5be Compare March 27, 2025 09:01
Base automatically changed from alex/23762_simsx_3 to release/v0.53.x March 28, 2025 16:12
@alpe alpe force-pushed the alex/23762_simsx_4 branch from c80c5be to 676b292 Compare March 28, 2025 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants