Skip to content

fix(testutil/integration): use only one context in integration test framework #24104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

hoangdv2429
Copy link
Contributor

Description

Closes: #23798
Backport


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@hoangdv2429
Copy link
Contributor Author

hoangdv2429 commented Mar 24, 2025

note: fail test what happen with module genesis initialize ? FeePool empty also return collections: not found: key 'no_key' .... Block height of previous test always run with with BlockHeight <=1 at all step, after it is increasing block_height > 1 making tests fail. Should we make the FeePool changing after each block or somehow make the block_height stay < 1 consistently like previous ?

@hoangdv2429
Copy link
Contributor Author

@aljo242 @technicallyty do you guys have any idea about this ?

@aljo242 aljo242 added the Cryostasis PRs that we're not quite sure on yet, but don't want to close. label Mar 26, 2025
@aljo242
Copy link
Contributor

aljo242 commented Mar 26, 2025

@hoangdv2429 going to put this on ice while we prioritize other work

@aljo242 aljo242 marked this pull request as draft March 27, 2025 16:40
@technicallyty technicallyty changed the base branch from release/v0.53.x to main April 1, 2025 17:54
@aljo242 aljo242 closed this May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/bank Cryostasis PRs that we're not quite sure on yet, but don't want to close.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove double context in integration tests v1
2 participants