Skip to content

Commit

Permalink
Remove endless loop detection to address linkedin#15.
Browse files Browse the repository at this point in the history
So the obvious downside is the risk of actually getting into an endless
loop but I think the risk is worth it.  If the code is solid then this
is not possible, so I'd rather address those cases as (if?) they come
up, instead causing false failures like the case in this issue.
  • Loading branch information
pgalbraith authored and cstroe committed Nov 4, 2018
1 parent 4ffb0c2 commit 8871477
Showing 1 changed file with 8 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,14 @@ public void testIssue13() {
runTest("[email protected]", UrlDetectorOptions.Default, "[email protected]");
runTest("first.middle.reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylonglastname@gmail.com", UrlDetectorOptions.Default, "first.middle.reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylonglastname@gmail.com");
}

/*
* https://github.com/linkedin/URL-Detector/issues/15
*/
@Test
public void testIssue15() {
runTest(".............:::::::::::;;;;;;;;;;;;;;;::...............................................:::::::::::::::::::::::::::::....................", UrlDetectorOptions.Default);
}

/*
* https://github.com/linkedin/URL-Detector/issues/15
Expand Down

0 comments on commit 8871477

Please sign in to comment.