Skip to content

Commit 8871477

Browse files
pgalbraithcstroe
authored andcommitted
Remove endless loop detection to address linkedin#15.
So the obvious downside is the risk of actually getting into an endless loop but I think the risk is worth it. If the code is solid then this is not possible, so I'd rather address those cases as (if?) they come up, instead causing false failures like the case in this issue.
1 parent 4ffb0c2 commit 8871477

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

src/test/java/com/linkedin/urls/detection/TestUriDetection.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -668,6 +668,14 @@ public void testIssue13() {
668668
runTest("[email protected]", UrlDetectorOptions.Default, "[email protected]");
669669
runTest("first.middle.reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylonglastname@gmail.com", UrlDetectorOptions.Default, "first.middle.reallyreallyreallyreallyreallyreallyreallyreallyreallyreallylonglastname@gmail.com");
670670
}
671+
672+
/*
673+
* https://github.com/linkedin/URL-Detector/issues/15
674+
*/
675+
@Test
676+
public void testIssue15() {
677+
runTest(".............:::::::::::;;;;;;;;;;;;;;;::...............................................:::::::::::::::::::::::::::::....................", UrlDetectorOptions.Default);
678+
}
671679

672680
/*
673681
* https://github.com/linkedin/URL-Detector/issues/15

0 commit comments

Comments
 (0)