Skip to content

feat(admin): bulk title-resync sweep reusing the extracted retry-sync reconcile - #564

Merged
tunile943 merged 1 commit into
masterfrom
feat/resync-titles-sweep
Aug 24, 2026
Merged

feat(admin): bulk title-resync sweep reusing the extracted retry-sync reconcile#564
tunile943 merged 1 commit into
masterfrom
feat/resync-titles-sweep

Conversation

@tunile943

@tunile943 tunile943 commented Aug 24, 2026

Copy link
Copy Markdown
Member

@coderabbitai summary

Description

  • services/syncOneMeeting.ts: the Retry-sync route's whole reconcile body extracted verbatim (Zoom credential adoption, family-aware mint/adopt with the Zoom host auto-assignment has a check-then-write race (TOCTOU) that can double-book a host #360 locking, calendar reconcile) so it can be invoked outside an HTTP request; app/api/update/meeting/sync/route.ts is now a thin wrapper around it.
  • app/api/admin/resync-titles/route.ts: admin-gated sweep that pushes live meetings' external names to the new fellowship-prefixed format. Dry-run is the default ({ dryRun: false } required to execute); paginated by mid cursor with a 25-row batch ceiling for Zoom rate limits, or scoped to explicit mids. Each executed row runs the same full reconcile as Retry sync, so pinned zoomTopic rows keep their verbatim Zoom names (their Calendar titles do adopt the new format — GCal has no pin) and unmanaged meetings are never PATCHed. Dry-run rows flag willProvisionZoom when executing would mint a Zoom meeting rather than just rename.
  • tests/integration/admin-resync-titles-route.test.ts: dry-run preview/default, mids-scoped execution, pinned-topic surfacing, deleted/suspended exclusion.

Testing

  • cd frontend && yarn test:integration tests/integration/admin-resync-titles-route.test.ts tests/integration/update-meeting-sync-route.test.ts
  • Rollout: POST /api/admin/resync-titles {"dryRun":true,"limit":25} as an admin, review results[].newTitle, then re-run with "dryRun":false, walking nextCursor until null.

Area(s) Touched

Product areas

  • auth — sign-in, sessions, NextAuth, role-based access
  • admin — /admin shell (Diagnostics, Users, Import, Export tabs)
  • docs — /docs Resources page (rendering, navigation, search)
  • ui/ux — frontend layout/styling not tied to a specific integration

Integrations

  • google-calendar — Google Calendar sync
  • zoom-api — Zoom meeting/host sync

Engineering

  • security — auth hardening, data exposure, dependency/security scanning
  • testing — test suite (Jest/Playwright) changes
  • github-actions — workflows, Dependabot config, other .github/ CI tooling
  • cleanup — refactor or dead-code removal, no behavior change
  • documentation — docs/ or README changes only

Pre-merge Checklist

  • Code follows current formatting conventions and passes lint (yarn lint).
  • Comments are appropriate — only where genuinely non-obvious, not restating what the code already says.
  • All test suites pass, both run locally and green in GitHub CI. Do not merge if any test suite is failing.
  • A test suite was added or updated for the feature/fix in this PR. Double-check this if you change a feature and did not update the test suites.
  • Only files relevant to this change are committed — no stray or unrelated files.
  • If this branch has a merge conflict with master, master was merged into this branch first (not the other way around).
  • The rest of this PR description (Description, Testing) is filled out, not left as template placeholders.

@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ithaca-recovery Ready Ready Preview Aug 24, 2026 2:13am

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 5eb3a489-d711-434b-b9d2-1f8a03451422

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tunile943
tunile943 marked this pull request as ready for review August 24, 2026 02:05
Base automatically changed from feat/fellowship-title-prefix to master August 24, 2026 02:11
@github-actions github-actions Bot added scope: admin /admin shell — Diagnostics, Users, Import, Export tabs scope: google-calendar Google Calendar sync (services/googleCalendar.ts) scope: testing Test suite (Jest/Playwright) changes scope: zoom-api Zoom meeting/host sync (services/zoom.ts) labels Aug 24, 2026
… reconcile

Extracts the Retry-sync route's body into services/syncOneMeeting.ts unchanged, and adds an
admin-gated POST /api/admin/resync-titles that walks live meetings in paginated batches --
dry-run preview by default, mids-scoped or cursor-driven execution runs the same full
reconcile per row, so pinned Zoom topics and unmanaged meetings keep their contracts.
@tunile943
tunile943 force-pushed the feat/resync-titles-sweep branch from f932688 to 506875b Compare August 24, 2026 02:11
@tunile943
tunile943 merged commit 7f6f525 into master Aug 24, 2026
13 of 14 checks passed
@tunile943
tunile943 deleted the feat/resync-titles-sweep branch August 24, 2026 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: admin /admin shell — Diagnostics, Users, Import, Export tabs scope: google-calendar Google Calendar sync (services/googleCalendar.ts) scope: testing Test suite (Jest/Playwright) changes scope: zoom-api Zoom meeting/host sync (services/zoom.ts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant