Skip to content

feat(meeting-form): fellowship prefix on external Zoom/Calendar titles - #563

Merged
tunile943 merged 1 commit into
masterfrom
feat/fellowship-title-prefix
Aug 24, 2026
Merged

feat(meeting-form): fellowship prefix on external Zoom/Calendar titles#563
tunile943 merged 1 commit into
masterfrom
feat/fellowship-title-prefix

Conversation

@tunile943

@tunile943 tunile943 commented Aug 24, 2026

Copy link
Copy Markdown
Member

@coderabbitai summary

Description

  • prisma/schema.prisma + migrations/20260823120000_add_meeting_fellowship: new nullable Meeting.fellowship column holding only the custom text typed behind the "Other" category; AA/Al-Anon are never stored redundantly — they derive from calType at title-build time.
  • util/meetings/linkedSchedules.ts: new fellowshipPrefixedTitle() helper — external names now read {Fellowship} {Title} - {Mode + days} (e.g. AA/Al-Anon Serenity Now - Hybrid Mon-Fri), fixed AA → Al-Anon → custom order, /-joined; no fellowship → title passes through unchanged.
  • services/zoom.ts + services/googleCalendar.ts: both title call sites route through the helper; a pinned zoomTopic still short-circuits first, so adopted legacy Zoom names are never renamed.
  • hooks/useMeetingForm.ts + NewMeeting/EditMeeting: a "Fellowship name (optional)" text input appears under the Categories checkboxes only while "Other" is checked; the payload nulls the value whenever "Other" is unchecked so a ghost prefix can't linger. Wired into dirty-tracking/reset.
  • meetingValidation.ts + write/update routes: fellowship declared in the zod schema (it strips undeclared keys) and added to the scoped-edit child and linked-sibling copy lists.

Testing

  • cd frontend && yarn test:unit tests/unit/linkedSchedules.test.ts tests/unit/zoom.test.ts tests/unit/googleCalendar.test.ts
  • yarn test:component tests/component/useMeetingForm.test.tsx tests/component/NewMeeting.test.tsx
  • yarn test:integration tests/integration/write-meeting-route.test.ts tests/integration/update-meeting-scoped-edit.test.ts
  • Manual: create a meeting with Categories AA + Other and a custom name — the Zoom topic and Calendar event title carry the AA/<custom> prefix.

Area(s) Touched

Product areas

  • auth — sign-in, sessions, NextAuth, role-based access
  • admin — /admin shell (Diagnostics, Users, Import, Export tabs)
  • docs — /docs Resources page (rendering, navigation, search)
  • ui/ux — frontend layout/styling not tied to a specific integration

Integrations

  • google-calendar — Google Calendar sync
  • zoom-api — Zoom meeting/host sync

Engineering

  • security — auth hardening, data exposure, dependency/security scanning
  • testing — test suite (Jest/Playwright) changes
  • github-actions — workflows, Dependabot config, other .github/ CI tooling
  • cleanup — refactor or dead-code removal, no behavior change
  • documentation — docs/ or README changes only

Pre-merge Checklist

  • Code follows current formatting conventions and passes lint (yarn lint).
  • Comments are appropriate — only where genuinely non-obvious, not restating what the code already says.
  • All test suites pass, both run locally and green in GitHub CI. Do not merge if any test suite is failing.
  • A test suite was added or updated for the feature/fix in this PR. Double-check this if you change a feature and did not update the test suites.
  • Only files relevant to this change are committed — no stray or unrelated files.
  • If this branch has a merge conflict with master, master was merged into this branch first (not the other way around).
  • The rest of this PR description (Description, Testing) is filled out, not left as template placeholders.

Deploy note: needs prisma migrate deploy (adds Meeting.fellowship).

External titles now read "{Fellowship} {Title} - {Mode}": AA/Al-Anon derive from the
Categories checkboxes, and checking Other reveals an optional custom fellowship name
stored in a new nullable Meeting.fellowship column. A pinned zoomTopic still wins.
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ithaca-recovery Ready Ready Preview Aug 24, 2026 1:45am

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 77a663d8-6844-4fee-a3d1-c6f0dc71a41d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@tunile943
tunile943 marked this pull request as ready for review August 24, 2026 02:05
@tunile943
tunile943 merged commit 22f81a9 into master Aug 24, 2026
16 checks passed
@tunile943
tunile943 deleted the feat/fellowship-title-prefix branch August 24, 2026 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant