Skip to content

feat(meeting-form): confirm-and-collapse step for schedules with mode-exact fields - #562

Merged
tunile943 merged 2 commits into
masterfrom
feat/schedule-confirm-flow-polish
Aug 24, 2026
Merged

feat(meeting-form): confirm-and-collapse step for schedules with mode-exact fields#562
tunile943 merged 2 commits into
masterfrom
feat/schedule-confirm-flow-polish

Conversation

@tunile943

Copy link
Copy Markdown
Member

@coderabbitai summary

Description

  • app/components/meeting-form/MeetingSchedules.tsx (+ .module.scss, util/rooms/modeFields.ts): the linked-schedule draft card now mounts only the fields its picked mode actually uses (modes={[draft.modeType]} — In Person → Room only, Remote → the inherited Zoom-host line only), instead of the superset of all still-selectable modes. Stale superset-mounting comments swept across MeetingForm.tsx, meetingValidation.ts, linkedSchedules.ts and tests.
  • Done buttons: both the draft card and the meeting's own recurrence editor get a Done button (bottom right) that collapses them into their ScheduleSummaryCard, each with an edit link to reopen (the draft's is visibly named by its mode to keep the two links distinguishable — WCAG 2.5.3). Done is disabled while there's nothing valid to summarize: no day, missing mode-required rooms, or an unreadable Date/Time. Display-only state — submission is untouched.
  • hooks/useMeetingForm.ts: switching the meeting's recurrence to Monthly (or off) while a draft is open now auto-discards the draft and raises an inline role="status" notice explaining why; the notice clears when the series is weekly again, and the collapse states reset alongside. The draft ref is nulled synchronously on every discard path so a same-commit recurrence report can't act on a stale draft.
  • app/components/meeting-form/RecurringMeeting.tsx (+ .module.scss, ui/inputs/RadioGroup.*): recurrence editor restyled to match the form — caption-style Repeats/Ends labels, 13px body instead of 18px, field-message error styling, inline styles/separator/dead CSS removed, and a new compact variant on RadioGroup (admin modals keep the full-size default).
  • docs/01-user-guide/how-to/set-up-a-recurring-meeting.md, docs/02-handoff/technical-decisions.md: updated for the per-mode fields, the Done/collapse step, and the auto-discard behavior.

Testing

  • yarn test:all from frontend/ — full suite green (384 unit / 415 component / 292 integration / 122 e2e; lint, stylelint, typecheck clean).
  • Manual: yarn dev, create a weekly meeting → "Add another mode for other days" → toggle the draft's mode (fields swap per mode) → pick days/room → Done collapses to a summary card; switch Repeats to Monthly → draft is discarded with the inline warning; switch back to Weekly → warning clears.

Area(s) Touched

Product areas

  • auth — sign-in, sessions, NextAuth, role-based access
  • admin — /admin shell (Diagnostics, Users, Import, Export tabs)
  • docs — /docs Resources page (rendering, navigation, search)
  • ui/ux — frontend layout/styling not tied to a specific integration

Integrations

  • google-calendar — Google Calendar sync
  • zoom-api — Zoom meeting/host sync

Engineering

  • security — auth hardening, data exposure, dependency/security scanning
  • testing — test suite (Jest/Playwright) changes
  • github-actions — workflows, Dependabot config, other .github/ CI tooling
  • cleanup — refactor or dead-code removal, no behavior change
  • documentation — docs/ or README changes only

Pre-merge Checklist

  • Code follows current formatting conventions and passes lint (yarn lint).
  • Comments are appropriate — only where genuinely non-obvious, not restating what the code already says.
  • All test suites pass, both run locally and green in GitHub CI. Do not merge if any test suite is failing.
  • A test suite was added or updated for the feature/fix in this PR. Double-check this if you change a feature and did not update the test suites.
  • Only files relevant to this change are committed — no stray or unrelated files.
  • If this branch has a merge conflict with master, master was merged into this branch first (not the other way around).
  • The rest of this PR description (Description, Testing) is filled out, not left as template placeholders.

…-exact fields

The linked-schedule draft now shows only the fields its picked mode uses, gains a Done
button that collapses it into a summary card (as does the meeting's own recurrence
editor), and is auto-discarded with an announced inline notice when the meeting stops
repeating weekly.
…ypography

Caption-style Repeats/Ends labels, form-scale radio options via a new RadioGroup
compact variant, field-message error styling, and no inline styles or separator.
@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 9f997061-bb7a-4776-8549-a2517cb04414

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added scope: testing Test suite (Jest/Playwright) changes scope: ui/ux Frontend layout/styling not tied to a specific integration type: documentation Improvements or additions to documentation. labels Aug 24, 2026
@vercel

vercel Bot commented Aug 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ithaca-recovery Ready Ready Preview Aug 24, 2026 12:35am

@tunile943
tunile943 merged commit d45ab3a into master Aug 24, 2026
16 checks passed
@tunile943
tunile943 deleted the feat/schedule-confirm-flow-polish branch August 24, 2026 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: testing Test suite (Jest/Playwright) changes scope: ui/ux Frontend layout/styling not tied to a specific integration type: documentation Improvements or additions to documentation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant