feat(meeting-form): confirm-and-collapse step for schedules with mode-exact fields - #562
Conversation
…-exact fields The linked-schedule draft now shows only the fields its picked mode uses, gains a Done button that collapses it into a summary card (as does the meeting's own recurrence editor), and is auto-discarded with an announced inline notice when the meeting stops repeating weekly.
…ypography Caption-style Repeats/Ends labels, form-scale radio options via a new RadioGroup compact variant, field-message error styling, and no inline styles or separator.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
@coderabbitai summary
Description
.module.scss,util/rooms/modeFields.ts): the linked-schedule draft card now mounts only the fields its picked mode actually uses (modes={[draft.modeType]}— In Person → Room only, Remote → the inherited Zoom-host line only), instead of the superset of all still-selectable modes. Stale superset-mounting comments swept acrossMeetingForm.tsx,meetingValidation.ts,linkedSchedules.tsand tests.ScheduleSummaryCard, each with an edit link to reopen (the draft's is visibly named by its mode to keep the two links distinguishable — WCAG 2.5.3). Done is disabled while there's nothing valid to summarize: no day, missing mode-required rooms, or an unreadable Date/Time. Display-only state — submission is untouched.role="status"notice explaining why; the notice clears when the series is weekly again, and the collapse states reset alongside. The draft ref is nulled synchronously on every discard path so a same-commit recurrence report can't act on a stale draft..module.scss,ui/inputs/RadioGroup.*): recurrence editor restyled to match the form — caption-style Repeats/Ends labels, 13px body instead of 18px, field-message error styling, inline styles/separator/dead CSS removed, and a newcompactvariant onRadioGroup(admin modals keep the full-size default).Testing
yarn test:allfromfrontend/— full suite green (384 unit / 415 component / 292 integration / 122 e2e; lint, stylelint, typecheck clean).yarn dev, create a weekly meeting → "Add another mode for other days" → toggle the draft's mode (fields swap per mode) → pick days/room → Done collapses to a summary card; switch Repeats to Monthly → draft is discarded with the inline warning; switch back to Weekly → warning clears.Area(s) Touched
Product areas
Integrations
Engineering
Pre-merge Checklist
yarn lint).