Migrate MUI system props to sx (fix MUI 9 build break) - #267
Merged
Conversation
MUI 9 removed support for system-style shorthand props passed directly
to Box/Typography (display, flexDirection, alignItems, mb, fontWeight,
fontFamily, etc.) and the Typography `paragraph` prop, which broke the
frontend build with TypeScript errors. Move those styles into `sx`, and
replace Drawer's removed `PaperProps` with `slotProps={{ paper }}`.
No visual change intended. `npm run build` passes (12/12 pages).
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Merging the dependency updates (#265) bumped MUI from v7 to v9, which removed two APIs the app relied on and broke the
mainbuild with TypeScript errors:Box/Typography(display,flexDirection,alignItems,justifyContent,mb,mt,fontWeight,fontFamily, etc.) are no longer accepted — they must go insx.Typographyparagraphprop was removed.Drawer'sPaperPropswas replaced byslotProps={{ paper }}.What
Moved all offending shorthand props into
sxand updated the Drawer slot API across:components/organisms/Home.tsxcomponents/organisms/SidePanel.tsx(incl.PaperProps→slotProps,paragraph→sx)components/molecules/Slide.tsxcomponents/molecules/SidePanelPercentageModal.tsxpages/about.tsxpages/methodology.tsxNo visual change intended — these are style-prop relocations only.
Verification
npx tsc --noEmit: 0 source errorsnpm run build: ✅ compiles, 12/12 static pages generatedRecommend merging this right after #265 to restore a green
main. (The Insights PR #266 also builds red until this lands, since it sits on the MUI 9main.)🤖 Generated with Claude Code