CC Autochecker Fail for past sem

backend/src/API/coffeeChatAPI.ts

@@ -193,6 +193,20 @@ export const runAutoChecker = async (uuid: string, user: IdolMember): Promise<Co
     throw new BadRequestError(`Coffee chat with uuid: ${uuid} does not exist`);
   }
 
+  const archivedChats = await coffeeChatDao.getCoffeeChatsByUser(
+    coffeeChat.submitter.email,
+    undefined,
+    coffeeChat.otherMember
+  );
+
+  const hasArchivedChat = archivedChats.some((chat) => chat.isArchived);
+
+  if (hasArchivedChat) {
+    throw new BadRequestError(
+      `Coffee chat with uuid: ${uuid} has an archived chat with the same submitter and other member`
+    );
+  }
+
   const result = await checkMemberMeetsCategory(
     coffeeChat.otherMember.email,
     coffeeChat.submitter.email,

backend/tests/CoffeeChatAPI.test.ts

@@ -8,10 +8,11 @@ import {
   updateCoffeeChat,
   deleteCoffeeChat,
   clearAllCoffeeChats,
-  checkMemberMeetsCategory
+  checkMemberMeetsCategory,
+  runAutoChecker
 } from '../src/API/coffeeChatAPI';
 import { setMember, deleteMember } from '../src/API/memberAPI';
-import { PermissionError } from '../src/utils/errors';
+import { BadRequestError, PermissionError } from '../src/utils/errors';
 
 const user = fakeIdolMember();
 const user2 = fakeIdolMember();
@@ -188,11 +189,64 @@ describe('User is lead or admin', () => {
   });
 });
 
+describe('runAutoChecker tests', () => {
+  const adminUser = fakeIdolLead();
+  const submitter = fakeIdolMember();
+  const otherMember = fakeIdolMember();
+  const coffeeChat = { ...fakeCoffeeChat(), submitter, otherMember };
+
+  beforeAll(() => {
+    const mockIsLeadOrAdmin = jest.fn().mockResolvedValue(true);
+    PermissionsManager.isLeadOrAdmin = mockIsLeadOrAdmin;
+  });
+
+  afterAll(() => {
+    jest.clearAllMocks();
+  });
+
+  test('runAutoChecker should throw error if coffee chat does not exist', async () => {
+    const mockGetCoffeeChat = jest.fn().mockResolvedValue(null);
+    CoffeeChatDao.prototype.getCoffeeChat = mockGetCoffeeChat;
+
+    await expect(runAutoChecker('fake-uuid', adminUser)).rejects.toThrow(
+      new BadRequestError(`Coffee chat with uuid: fake-uuid does not exist`)
+    );
+  });
+
+  test('runAutoChecker should throw error if archived chat exists with same submitter and other member', async () => {
+    const mockGetCoffeeChat = jest.fn().mockResolvedValue(coffeeChat);
+    const mockGetCoffeeChatsByUser = jest
+      .fn()
+      .mockResolvedValue([{ ...coffeeChat, isArchived: true }]);
+    CoffeeChatDao.prototype.getCoffeeChat = mockGetCoffeeChat;
+    CoffeeChatDao.prototype.getCoffeeChatsByUser = mockGetCoffeeChatsByUser;
+
+    await expect(runAutoChecker(coffeeChat.uuid, adminUser)).rejects.toThrow(
+      new BadRequestError(
+        `Coffee chat with uuid: ${coffeeChat.uuid} has an archived chat with the same submitter and other member`
+      )
+    );
+  });
+
+  test('runAutoChecker should update coffee chat if no archived chat exists', async () => {
+    const mockGetCoffeeChat = jest.fn().mockResolvedValue(coffeeChat);
+    const mockGetCoffeeChatsByUser = jest.fn().mockResolvedValue([]);
+    const mockUpdateCoffeeChat = jest.fn().mockResolvedValue(coffeeChat);
+    CoffeeChatDao.prototype.getCoffeeChat = mockGetCoffeeChat;
+    CoffeeChatDao.prototype.getCoffeeChatsByUser = mockGetCoffeeChatsByUser;
+    CoffeeChatDao.prototype.updateCoffeeChat = mockUpdateCoffeeChat;
+
+    const result = await runAutoChecker(coffeeChat.uuid, adminUser);
+    expect(result).toBeDefined();
+    expect(CoffeeChatDao.prototype.updateCoffeeChat).toBeCalled();
+  });
+});
+
 describe('More complicated member meets category checks', () => {
   const admin = { ...fakeIdolLead() };
   const user1 = fakeIdolMember();
-  const user2 = { ...fakeIdolMember(), role: 'dev-advisor' as Role };
-  const user3 = { ...fakeIdolMember(), role: 'tpm' as Role };
+  const user2 = { ...fakeIdolMember(), role: 'dev-advisor' };
+  const user3 = { ...fakeIdolMember(), role: 'tpm' };
   const user4 = { ...fakeIdolMember(), semesterJoined: 'Spring 2025' };
 
   beforeAll(async () => {

backend/tests/CoffeeChatDao.test.ts

@@ -5,7 +5,7 @@ import { coffeeChatsCollection } from '../src/firebase';
 const user = fakeIdolMember();
 const user2 = fakeIdolMember();
 const mockCC = { ...fakeCoffeeChat(), submitter: user };
-const mockCC2 = { ...fakeCoffeeChat(), status: 'accepted' as Status, submitter: user };
+const mockCC2 = { ...fakeCoffeeChat(), status: 'accepted', submitter: user };
 const mockCC3 = { ...fakeCoffeeChat(), submitter: user, otherMember: user2 };
 
 const coffeeChatDao = new CoffeeChatDao();
@@ -31,7 +31,7 @@ test('Get coffee chat by user', () =>
   }));
 
 test('Get coffee chat by user with status', () =>
-  coffeeChatDao.getCoffeeChatsByUser(user.email, 'accepted' as Status).then((coffeeChats) => {
+  coffeeChatDao.getCoffeeChatsByUser(user.email, 'accepted').then((coffeeChats) => {
     expect(coffeeChats.some((submission) => submission === mockCC)).toBe(false);
     expect(coffeeChats.some((submission) => submission === mockCC2));
     expect(coffeeChats.some((submission) => submission === mockCC3)).toBe(false);