Ignore Markdown code when parsing wikilinks#53
Merged
Conversation
R's [[ ]] list indexing inside fenced blocks or inline code spans was being extracted as wikilinks, producing spurious broken-link findings in lint(). strip_code() drops fenced blocks and inline spans before the [[...]] regex runs, so outlinks/backlinks/vault_graph see real links only.
# Conflicts: # DESCRIPTION # NEWS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
parse_wikilinks()ran a bare\[\[([^]]+)\]\]regex over every line, with no awareness of code regions. R's[[ ]]list indexing inside a fenced block or inline code span got extracted as a wikilink, solint()reported spurious broken links for ordinary code samples:`merged[[name]] <- project[[name]]`→ broken linkname.subagent_registry[[uuid]]in a fenced diagram → broken linkuuidFix
New
strip_code()helper blanks out code before extraction:```/~~~) are dropped via a vectorizedcumsumfence tracker.`...`) are stripped from the remaining lines.parse_wikilinks()calls it first, solint(),outlinks(),backlinks(), andvault_graph()all benefit.Tests
Added a
test_parse.Rcase with[[ ]]in both a fenced block and an inline span, asserting real links still resolve and code-embedded ones don't. Full suite: 583 results, all OK.Version
Bumped to 0.6.3.3 (dev marker), separate commit.