Extract Matrix plumbing to mx.client behind namespace guards#136
Merged
Conversation
The Matrix adapter duplicated mx.client's stateful plumbing. Delegate it: config persistence (path/legacy/load/save), session construction, the markdown->HTML converter, and the sync-event extractors (messages, invites, reaction verdicts) now call mx.client. corteza keeps its agent runtime (bot loop, command parsing, tool approval, chat sessions, archiving, flush signals) -- the part that isn't a generic client. mx.client is a Suggests (alongside mx.api) and used via requireNamespace, so corteza stays CRAN-safe until mx.client publishes; then it graduates to Imports and the guards drop. Matrix tests skip when mx.client is absent. Net -163 lines in matrix.R; markdown output verified byte- identical; full suite green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7 from the cerebro work list. The Matrix adapter duplicated mx.client's stateful plumbing; delegate it.
Delegated to mx.client (verified byte-identical / signature-compatible): config persistence (
config_path/legacy/load/save), session construction, the markdown→HTML converter, and the sync extractors (messages/invites/reaction verdicts). Net -163 lines in matrix.R.Stays in corteza — the agent runtime, not a generic client: bot loop, command parsing, tool-approval-via-reactions, chat sessions, transcript archiving, flush signals. Also
matrix_configure(stores corteza-only fields) andmatrix_accept_invites(session-signature).mx.client is a Suggests used via
requireNamespace(same pattern as mx.api), so corteza stays CRAN-safe until mx.client publishes — then it graduates to Imports and the guards drop. Matrix tests skip when mx.client is absent. Full suite green (2331).