Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): template CRDs apart of the chart package process #5

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

anthr76
Copy link
Member

@anthr76 anthr76 commented Aug 13, 2024

.values.installCRDs appears to have the operator load the CRDs from helm values after a helm install/upgrade is processed. In argo helm installs are essentially templated out so the operator doesn't have a concept of what was set. So in CI we create a template for values.installCRDs on whether to install the CRDs or not via helm.

  • Also ensure pushing of helm charts only happens on the default branch
  • Disabled container builds on PRs unless the CI file was changed manual builds can be kicked off with a workflow_dispatch

@anthr76 anthr76 changed the title fix: package CRDs apart of the cchart CI process fix: package CRDs apart of the chart CI process Aug 13, 2024
Signed-off-by: Anthony Rabbito <[email protected]>
@anthr76 anthr76 changed the title fix: package CRDs apart of the chart CI process fix(ci): template CRDs apart of the chart package process Aug 13, 2024
Signed-off-by: Anthony Rabbito <[email protected]>
@ChandonPierre ChandonPierre merged commit 22c03f5 into coreweave Aug 13, 2024
1 of 2 checks passed
@anthr76 anthr76 deleted the anthr76/crd-helm branch August 13, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants