Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[rhcos-4.12] mantle/kola: change URLs for coreos.tls.fetch-urls test #4004

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[rhcos-4.12] mantle/kola: change URLs for coreos.tls.fetch-urls test #4004

merged 1 commit into from
Jan 20, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #4003

/assign dustymabe

@dustymabe
mantle/kola: change URLs for coreos.tls.fetch-urls test
5558e42 
These were changed to other URLs when the test moved to an external
test in coreos/fedora-coreos-config@41901c7

Let's update the URLs for older releases too to simplify our allow
rules for external domains.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 20, 2025
Merged
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

Hi @openshift-cherrypick-robot. Thanks for your PR.

I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dustymabe
Copy link
Member

/label ok-to-test

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 20, 2025

@dustymabe: The label(s) /label ok-to-test cannot be applied. These labels are supported: acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, no-qe, downstream-change-needed, rebase/manual, cluster-config-api-changed, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

marmijo
marmijo approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@marmijo marmijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dustymabe dustymabe merged commit 16f3c06 into coreos:rhcos-4.12 Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marmijo marmijo marmijo approved these changes

Assignees

@dustymabe dustymabe

Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@openshift-cherrypick-robot @dustymabe @marmijo