Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd-coreos-prune: replace pytz to datetime #4002

Merged
merged 1 commit into from
Jan 17, 2025
Merged

cmd-coreos-prune: replace pytz to datetime #4002

merged 1 commit into from
Jan 17, 2025

Conversation

HuijingHei
Copy link
Member

@HuijingHei HuijingHei commented Jan 16, 2025 •
edited
Loading

Xerf to #273
Fix CI failed issue:

src/cmd-coreos-prune:39:0: E0401: Unable to import 'pytz' (import-error)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 16, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@HuijingHei HuijingHei marked this pull request as ready for review January 16, 2025 13:37
@jlebon
Copy link
Member

jlebon commented Jan 16, 2025

Looks like that worked. I'm all for getting rid of pytz in favour of datetime. Want to update your commit message?

@HuijingHei
cmd-coreos-prune: replace pytz to datetime
61c9e88 
Xerf to coreos#273
Fix CI failed issue:
```
src/cmd-coreos-prune:39:0: E0401: Unable to import 'pytz' (import-error)
```
@HuijingHei HuijingHei changed the title debug failed CI (Unable to import 'pytz') cmd-coreos-prune: replace pytz to datetime Jan 17, 2025
@HuijingHei
Copy link
Member Author

Looks like that worked. I'm all for getting rid of pytz in favour of datetime. Want to update your commit message?

Updated, thanks!

@cverna
Copy link
Member

cverna commented Jan 17, 2025

👍 , LGTM

@HuijingHei HuijingHei merged commit 09868d1 into coreos:main Jan 17, 2025
5 checks passed
@HuijingHei HuijingHei deleted the remove-pytz branch January 17, 2025 08:44
@HuijingHei HuijingHei mentioned this pull request Jan 17, 2025
Merged
@mike-nguyen
Copy link
Member

Thanks for fixing @HuijingHei !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cverna cverna cverna approved these changes

@gursewak1997 gursewak1997 Awaiting requested review from gursewak1997

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HuijingHei @jlebon @cverna @mike-nguyen