Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced ability to use KEDA triggers for autoscaling #166

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritmas
Copy link

@ritmas ritmas commented May 13, 2024

Why is this pull request needed and what does it do?

Introduced ability to use KEDA triggers for autoscaling

Which issues (if any) are related?

N/A

Checklist:

  • I have bumped the chart version according to versioning.
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.

Changes are automatically published when merged to main. They are not published on branches.

Note on DCO

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

@ritmas
Copy link
Author

ritmas commented May 15, 2024

@hagaibarel what's missing for this PR to be merged?

@hagaibarel
Copy link
Collaborator

@ritmas I haven't got the chance to take a good look at this yet, but I'm curious why do you think we need another scaling option (aside from the hpa and the proportional-sutoscaler)?

I would like to understand the use case for this functionallity

@ritmas
Copy link
Author

ritmas commented May 15, 2024

HPA is raw/native k8s approach for setting up deployment's autoscaling which is smoothly covered by high-level managers like KEDA or cluster-proportional-autoscaler itself.

I don't work with the latter one so I'm not familiar with it nor willing to due to wide adoption of KEDA within projects I'm working with. Another tool's adoption would increase personal work complexity on daily basis.

From community point of view, based on Github popularity (stars/forks), KEDA is more popular one and it should give more flexibility to use coreDNS itself.

@hagaibarel
Copy link
Collaborator

I understand what you're saying, but I'm trying to understand the usecase of introducing (yet) another way of auto scaling coredns

@ritmas
Copy link
Author

ritmas commented May 15, 2024

My usecase is to auto-scale based on DNS request lag (coredns_dns_request_duration_seconds_bucket), which is a custom/external metric and requires extra service/adapter in the scope.

It might be metrics-server, prometheus-adapter or in GCP case Stackdriver Adapter. But I don't want either of these as KEDA has it's own metrics server and it's already running on my clusters.

So this PR would allow me to use Prometheus scaler and auto-scale based on that metric.

@hagaibarel

@ritmas
Copy link
Author

ritmas commented May 17, 2024

@hagaibarel is this use-case enough to accept this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants