Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opentelemetry-integration] chore: add prometheus receiver debuging docs #487

Merged
merged 1 commit into from
Dec 16, 2024
Merged

[opentelemetry-integration] chore: add prometheus receiver debuging docs #487

merged 1 commit into from
Dec 16, 2024

Conversation

povilasv
Copy link
Contributor

Description

Fixes https://coralogix.atlassian.net/browse/ES-396

Some learnings after a debugging session with a customer :)

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv force-pushed the prometheus branch 3 times, most recently from f3dbdcf to 9be00cb Compare December 16, 2024 12:40
@povilasv povilasv marked this pull request as ready for review December 16, 2024 12:46
daidokoro
daidokoro approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@daidokoro daidokoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@povilasv povilasv merged commit 4d34383 into master Dec 16, 2024
6 of 7 checks passed
@povilasv povilasv deleted the prometheus branch December 16, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolastakashi nicolastakashi nicolastakashi approved these changes

@daidokoro daidokoro daidokoro approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @daidokoro @nicolastakashi