[otel-integration] add otel-integration version header #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
povilasv
force-pushed
the
otel-integration-version
branch
2 times, most recently
from
fe6b8a6 to
6fe845c
Compare
povilasv
force-pushed
the
otel-integration-version
branch
from
6fe845c to
4fced6f
Compare
povilasv
requested review from
avivgold098,
ShauliSolomovich,
oded-dd,
matej-g and
nicolastakashi
as code owners
matej-g
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a new global field that will have otel-integration version and then passes it via header. We will need to maintain Chart.yaml with this global value.
In helm it looks like it is not possible to pass the parent chart version. {{Chart.Version}} always renders subchart version. I tried to hack around it with tpl and other ways but didnt find a solution.
Also added a CI job to verify that this value matches the Chart.yaml. Example CI failure -> https://github.com/coralogix/telemetry-shippers/actions/runs/8108799144/job/22162697146?pr=376
Fixes ES-212
How Has This Been Tested?
Checklist: