Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CHORE] adding prom agent image pull secrets #362

Merged
merged 1 commit into from
Feb 7, 2024
Merged

[CHORE] adding prom agent image pull secrets #362

merged 1 commit into from
Feb 7, 2024

Conversation

nicolastakashi
Copy link
Contributor

Description

Adding the template to include image pull secrets

How Has This Been Tested?

I run helm template with two different configs with image pull secrets and without image pull secrets.

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@nicolastakashi nicolastakashi merged commit 553f45c into master Feb 7, 2024
3 of 4 checks passed
@nicolastakashi nicolastakashi deleted the chore/adding-prom-agent-image-pull-secrets branch February 7, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShauliSolomovich ShauliSolomovich ShauliSolomovich approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@matej-g matej-g Awaiting requested review from matej-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolastakashi @ShauliSolomovich