Collection interval feature #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
Signed-off-by: Matej Gera <[email protected]>
matej-g
requested review from
avivgold098,
ShauliSolomovich,
povilasv,
oded-dd and
nicolastakashi
as code owners
matej-g
force-pushed
the
collection-interval-feat
branch
from
ee378e8 to
51692ce
Compare
Signed-off-by: Matej Gera <[email protected]>
matej-g
force-pushed
the
collection-interval-feat
branch
from
51692ce to
a9c1fd2
Compare
povilasv
reviewed
Jan 25, 2024
Signed-off-by: Matej Gera <[email protected]>
povilasv
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://coralogix.atlassian.net/browse/ES-191
Adds global collection interval parameter for better user experience and sets default to 30s.
Additionally, adds suppression of another "duplicated" attribute (
service.name- similar to #352)Add some more documentation around using Windows images.
How Has This Been Tested?
Locally with
kindChecklist: