Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] feat: add support for gke/autopilot #339

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[otel-integration] feat: add support for gke/autopilot #339

merged 3 commits into from
Dec 4, 2023

Conversation

povilasv
Copy link
Contributor

@povilasv povilasv commented Dec 1, 2023

Description

Fixes https://coralogix.atlassian.net/browse/ES-152

How Has This Been Tested?

Run in gke autopilot cluster

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review December 1, 2023 11:48
matej-g
matej-g reviewed Dec 1, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small doc suggestions and optional suggestion about how to construct the values file.

otel-integration/k8s-helm/README.md Outdated Show resolved Hide resolved
otel-integration/k8s-helm/README.md Outdated Show resolved Hide resolved
otel-integration/k8s-helm/README.md Outdated Show resolved Hide resolved
otel-integration/k8s-helm/README.md Outdated Show resolved Hide resolved
otel-integration/k8s-helm/gke-autopilot-values.yaml Show resolved Hide resolved
@povilasv
Copy link
Contributor Author

povilasv commented Dec 1, 2023

@matej-g updated PR, when you have time please review :)

matej-g
matej-g approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌 , thank you!

@povilasv povilasv merged commit 0e74887 into master Dec 4, 2023
3 checks passed
@povilasv povilasv deleted the gke-autopilot branch December 4, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@povilasv @matej-g