Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] Add span metrics preset #334

Merged
merged 5 commits into from
Nov 28, 2023
Merged

[otel-integration] Add span metrics preset #334

merged 5 commits into from
Nov 28, 2023

Conversation

matej-g
Copy link
Contributor

@matej-g matej-g commented Nov 27, 2023 •
edited
Loading

Description

Fixes https://coralogix.atlassian.net/browse/ES-126

Removes deprecated spanmetricsprocessor and adds preset for spanmetricsconnector instead. Adds documentation and explains how to fix bad instrumentation / high cardinality issue with the preset.

Includes BREAKING CHANGE - until this release, span metrics were enabled by default; from this release, the span metrics are disabled by default and must be enabled manually by user.

How Has This Been Tested?

Locally on kind

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

povilasv
povilasv approved these changes Nov 28, 2023
View reviewed changes
Copy link
Contributor

@povilasv povilasv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider also adding something to ugrading.md

@matej-g
Add UPGRADING section
f41207e 
Signed-off-by: Matej Gera <[email protected]>
@matej-g
Formatting fixes
e8cfead 
Signed-off-by: Matej Gera <[email protected]>
@matej-g matej-g marked this pull request as ready for review November 28, 2023 11:44
@matej-g matej-g changed the title Add span metrics preset [otel-integration] Add span metrics preset Nov 28, 2023
@matej-g matej-g merged commit 9f58190 into coralogix:master Nov 28, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@povilasv povilasv povilasv approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@oded-dd oded-dd Awaiting requested review from oded-dd oded-dd is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matej-g @povilasv