Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[otel-integration] add upgrading docs #331

Merged
merged 2 commits into from
Nov 21, 2023
Merged

[otel-integration] add upgrading docs #331

merged 2 commits into from
Nov 21, 2023

Conversation

povilasv
Copy link
Contributor

Description

Fixes #ES-147

How Has This Been Tested?

Checklist:

  • I have updated the relevant Helm chart(s) version(s)
  • I have updated the relevant component changelog(s)
  • This change does not affect any particular component (e.g. it's CI or docs change)

@povilasv povilasv marked this pull request as ready for review November 20, 2023 13:23
oded-dd
oded-dd reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@oded-dd oded-dd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should emphasize the fact that this is a breaking change

@povilasv
Copy link
Contributor Author

povilasv commented Nov 20, 2023 •
edited
Loading

@oded-dd Where do you want to add it?

I don't think it is a breaking change, as I don't think a lot of users override cluster collector's metrics pipeline. And if they don't it just works automatically.

matej-g
matej-g approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nits, looks good 👍

otel-integration/UPGRADING.md Outdated Show resolved Hide resolved
otel-integration/UPGRADING.md Outdated Show resolved Hide resolved
@povilasv povilasv merged commit 1386e98 into master Nov 21, 2023
2 checks passed
@povilasv povilasv deleted the docs branch November 21, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oded-dd oded-dd oded-dd left review comments

@matej-g matej-g matej-g approved these changes

@avivgold098 avivgold098 Awaiting requested review from avivgold098 avivgold098 is a code owner

@ShauliSolomovich ShauliSolomovich Awaiting requested review from ShauliSolomovich ShauliSolomovich is a code owner

@nicolastakashi nicolastakashi Awaiting requested review from nicolastakashi nicolastakashi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@povilasv @oded-dd @matej-g