resource Pr60, enhancements to the routing tab #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…leting of resource steps. also rebased to current CORAL version
…usergroup doesn't do anything. changing the usergroup for a resourcestep does not start steps that are not yet active.
… it now can apply the new user group to all later steps. fixed the applyToAll form to actually check the checkbox before applying to all
…on resource steps and to delete steps.
# Conflicts: # ajax_htmldata/getRoutingDetails.php
Javascript strings that have to be translated must be enclosed within _() This small patch fixes a forgotten string.
queryluke
pushed a commit
to queryluke/coral
that referenced
this pull request
Jan 22, 2020
Terms tool css update
streatim
referenced
this pull request
in ml-systems-um/coral-drbn
Feb 21, 2025
Updates the Tax included and Final cost values when the Tax Excluded or Tax Rate values are changed in the Resources cost history form. Partially fixes #13. Signed-off-by: Stephanie Leary <[email protected]>
streatim
referenced
this pull request
in ml-systems-um/coral-drbn
Feb 21, 2025
Corrects issues with adding and removing rows from the Resources > Acquisitions cost history table. Does not resolve underlying issues with cost history data being deleted if any input data is invalid; see coral-erm#707. Fixes #13. Signed-off-by: Stephanie Leary <[email protected]>
streatim
added a commit
that referenced
this pull request
Apr 11, 2025
* Accessibility cleanup: core files Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Auth module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Licensing module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Management module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Organizations module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Reports module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Resources module Signed-off-by: Stephanie Leary <[email protected]> * Accessibility cleanup: Usage module Signed-off-by: Stephanie Leary <[email protected]> * Refactor Utility->getCORALPath() Very mild refactor of Utility->getCORALPPath(), adding a comment for future development and ensuring the pathway doesn't include two forward slashes (which never broke it, but let's go ahead and update it while looking at it) * Update index.php Updates the main CORAL page to not use templates/footer.php (much like it doesn't use templates/header.php). Also removes the unset $coralPath variables from header images. * Module Footer Adjustments Comments out code that was already being set in the module's index.php scripts (much like it was in the resources module). When uncommented it broke the footer in Organizations. * Module Header Adjustments Switches module includes for Organizations, Resources, and Usage to use relative pathing rather than DOCUMENT_ROOT. * Common Template Pathing Makes use of the $coralPath value to link to images and adds a "/" to the start of 231 that was incorrectly returning false. * Remove leading slash from icons * Correcting order of includes in usage/templates/header.php * Update index.php Adds a color mode toggle to the main page - basically copy-pasted the code from templates/header.php and added a label. * PHP count() error, layout fixes for import config Corrects the PHP 8 count() errors that prevented the Resources import configuration form from loading completely. Adjusts the layout and corrects issues with the form labels and IDs. Signed-off-by: Stephanie Leary <[email protected]> * Fix count() errors Always check whether an array exists before passing it into count(), which throws an error in PHP 8. Signed-off-by: Stephanie Leary <[email protected]> * Eliminate .save-button link classes Removes the "save-button" class from various links, including the "Delete publisher" and "Delete platform" links in SUSHI reports. Fixes #3. Signed-off-by: Stephanie Leary <[email protected]> * Links styled as buttons should be blocks Links that are styled as buttons (such as the "send feedback" link in Resources' Helpful Links sidebar) should be styled as block-level elements, not inline, and their text should be centered. Fixes #7. Signed-off-by: Stephanie Leary <[email protected]> * Fix error & success message colors in Management In the New Document form, fix file upload success message that was incorrectly styled as an error, and remove non-breaking space that forced the error message region to appear under the document title when no errors were present. Fixes #17. Signed-off-by: Stephanie Leary <[email protected]> * Prevent double logo display Move CORAL logos to background images for better control of light and dark versions in cases where the data-color-scheme attribute is not set correctly. Fixes #2. Signed-off-by: Stephanie Leary <[email protected]> * Condense contact lists Restores table-like headers for contacts' names, tightens the line spacing within the contact, and adds whitespace between consecutive contacts. Also separates Names and Roles into their own labeled lines. Fixes #15. Signed-off-by: Stephanie Leary <[email protected]> * SUSHI dialog form cleanup Removes extraneous table markup from dialogs related to SUSHI platforms and reports. Fixes #5. Signed-off-by: Stephanie Leary <[email protected]> * Fix display of Notes in Resources > Access Corrects the display of notes in the Resources module, particularly in the Access section. Fixes #14. Signed-off-by: Stephanie Leary <[email protected]> * Fix SUSHI platform side navigation menu Fixes broken links in the Usage > SUSHI section's side navigation menu. Also corrects styling of the "Delete" link for publishers and platforms. Fixes #4. Signed-off-by: Stephanie Leary <[email protected]> * clear TODO on SUSHI navigation Signed-off-by: Stephanie Leary <[email protected]> * Populate Tax included and Final cost values Updates the Tax included and Final cost values when the Tax Excluded or Tax Rate values are changed in the Resources cost history form. Partially fixes #13. Signed-off-by: Stephanie Leary <[email protected]> * Fix add/remove row functions in cost history table Corrects issues with adding and removing rows from the Resources > Acquisitions cost history table. Does not resolve underlying issues with cost history data being deleted if any input data is invalid; see #707. Fixes #13. Signed-off-by: Stephanie Leary <[email protected]> * Add validation for checkboxes in management Adds a validation function for groups of checkboxes where at least one value must be selected. Also corrects message color for successfully uploaded documents. Fixes #18. Signed-off-by: Stephanie Leary <[email protected]> * Fix Resources Edit/Clone Order form layout Removes layout tables from the Edit/Clone Order form in the Resources module and updates form labels and fieldsets. Fixes #8. Signed-off-by: Stephanie Leary <[email protected]> * Fix form layouts in issue & downtime forms Removes layout tables and corrects layout issues in the various forms for reporting issues and downtime across all modules. Fixes #21. Signed-off-by: Stephanie Leary <[email protected]> * Fix styling in Licensing form dialogs Signed-off-by: Stephanie Leary <[email protected]> * Use sprintf() formatting for translated strings Replaces concatenated strings with sprintf() formatted placeholders. Signed-off-by: Stephanie Leary <[email protected]> * Remove dialog inline height and width styles Removes the pixel-specific inline styles for modal dialogs' height and width. Uses global styles instead to set min and max sizes in viewport units. Adds responsive styles for dialog margins on mobile. Signed-off-by: Stephanie Leary <[email protected]> * Change datepicker start date from 1996 to 2025 Signed-off-by: Stephanie Leary <[email protected]> * Styling for invalid form inputs Signed-off-by: Stephanie Leary <[email protected]> * Management upload document JS fix; form layout Fixes an issue with the confirmation strings when files are uploaded to the Management module; corrects form layout issues with confirmation messages and checkbox labels. Signed-off-by: Stephanie Leary <[email protected]> * Responsive styling for large/wide forms Signed-off-by: Stephanie Leary <[email protected]> * String corrections for uploaded file name messages Signed-off-by: Stephanie Leary <[email protected]> * form cleanup Signed-off-by: Stephanie Leary <[email protected]> * Adjust product details <dl> Signed-off-by: Stephanie Leary <[email protected]> * Allow <div> in .dl-grid Signed-off-by: Stephanie Leary <[email protected]> * Autosuggest color corrections Signed-off-by: Stephanie Leary <[email protected]> * i18n for "Action %s not set up" Signed-off-by: Stephanie Leary <[email protected]> * Use getTarget() for all links that open in new tabs Signed-off-by: Stephanie Leary <[email protected]> * SUSHI Import Confirmation: Confirm button color Fixes the color and button type of the "Confirm" button in the SUSHI Import screen. Fixes #23. Signed-off-by: Stephanie Leary <[email protected]> * Spacing between Platform Name and Edit Link Space out "edit report display name" links from their platform names. Fixes #24. Signed-off-by: Stephanie Leary <[email protected]> * Usage Reports menu item may open in a new tab Add the target attribute, if the site configuration allows, to the Usage Reports menu item in the Usage module so that it opens in a new tab. Fixes #25. Signed-off-by: Stephanie Leary <[email protected]> * Style bylines consistently Signed-off-by: Stephanie Leary <[email protected]> * Right panel spacing, semantics Signed-off-by: Stephanie Leary <[email protected]> * Silence "Action Not Set Up" errors for empty requests Do not return "Action Not Set Up" messages for empty ajax requests. Fixes #20. Signed-off-by: Stephanie Leary <[email protected]> * more getTarget() for links Signed-off-by: Stephanie Leary <[email protected]> * Standardize language dropdown Use the language <select> defined in LangCodes.php throughout. Fixes #12. Signed-off-by: Stephanie Leary <[email protected]> * Use light/dark logos in main index footer Updates the logo markup in the main index page's footer. Also sets JS constants on this page where the config file is not read. Signed-off-by: Stephanie Leary <[email protected]> * Put language chooser first in main index header Signed-off-by: Stephanie Leary <[email protected]> * Fieldset for date range search inputs Signed-off-by: Stephanie Leary <[email protected]> * Show import history table only if data exists Signed-off-by: Stephanie Leary <[email protected]> * eliminate tables from Resource print summary Signed-off-by: Stephanie Leary <[email protected]> * date & numeric formatting for table columns Signed-off-by: Stephanie Leary <[email protected]> * Link colors in error, warning, success messages Signed-off-by: Stephanie Leary <[email protected]> * Add main ARIA role to login form Signed-off-by: Stephanie Leary <[email protected]> * Table form cleanup Signed-off-by: Stephanie Leary <[email protected]> * Resources > Workflow User Groups form validation Refactors the Resources > Workflow User Groups form to eliminate layout tables and revises the associated JS form validation and action button events to match the new markup. Signed-off-by: Stephanie Leary <[email protected]> * Fix URLs with extraneous 'target' attribute Signed-off-by: Stephanie Leary <[email protected]> * Correct error/warning/success message colors Signed-off-by: Stephanie Leary <[email protected]> * Resolves Issue #622 Enhancement Adds Order Number Searching to the main Resources Menu. * Update AuthenticationType.php Corrects the table where the AuthenticationTypeIDs are being stored. Fixes a delete bug mentioned in #714. * Adds Secure Links to coral-erm site Adds https:// to links that land on Coral's main website. Partially resolves Issue #786 * Initial Change * Update ajax_htmldata.php Minor bugfixes to initial changes. * Update admin.js Updates the stats check for the Resources Admin Resource Type form. * Create 001-645.sql Updates ResourcePayment table to allow negative integers in the paymentAmount, priceTaxExcluded, and priceTaxIncluded columns. * Update style.css Adds styling to a new addPayment input for the cost history forms. * Update getAcquisitionsDetails.php Cleans up the Acquisition Details htmldata forms; the div fullRightPanel was set up to always show (even with the jquery Hide action in this), so we take it out. It also cleans up the ternary operators to set payments from the payment array. * Update Payment History Form Refactors the Payment History form to: - allow negative values in the payment inputs - Reorganize the HTML form's names to tie row inputs together - Fixes the Add/Delete row events that seemed to have been broken by UI changes. - Fixes the processing of the forms so that -rather than deleting all payment rows in the Database and reinserting the information provided by the HTML form- rows are inserted, updated, and deleted based off of what happened in the form. - Updates the HTML form to add attributes to help ensure the form inputs match the Database structure (for example, input numbers for most integer values; max string-length for varchar fields) * Updates Folder Updates the MySQL Update folder to use the correct version (2025.04; not 2025.4) * Update getCostForm.php Removes a style test that was accidentally committed. * Version Number Updates Updates the version numbers and the install process. * Update Resources install script Removes read/write config access for resources. This was incorrectly here because I copy-pasted code without reading it carefully. --------- Signed-off-by: Stephanie Leary <[email protected]> Co-authored-by: Stephanie Leary <[email protected]> Co-authored-by: streatim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a copy of the ndlibersa/resources#60
It adds a tiny patch to ensure translatability of a javascript string