-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header and footer for new website (rocq-prover.org) integration #87
Conversation
@proux01 This changes the styling but it is not definitive (@BastienSozeau needs to adapt it still). Am I understanding correctly that this won't anyway affect released versions (e.g. 8.20.1) if we break things (visually) by modifying the html. |
Right, the |
</div> | ||
</div> | ||
</div> | ||
</div> | ||
|
||
</div> | ||
</main> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit weird. This means that by default, the produced HTML will not be valid. We have to keep in mind that some people would like to view the doc locally. In this case, it is fine to not have any header / footer, but not to have broken HTML.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry, I didn't realize that this is closing tags that are opened in the header!
Indeed, the current stdlib repo is only used for the v9.0 and master branches of coq repo. |
@mattam82 what is the status of this? should it be merged? what about Corelib in the core repo? |
This can be merged already and improved upon afterwards. |
I'll make a PR for Corelib as well |
Remove playground option, disabled for now
Restore missing closing tag
Failures seem unrelated. |
Thanks |
This allows to integrate the generated HTML smoothly into the new rocq-prover.org website.
Fixes coq/coq#19976