Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't leak the token in the error message #317

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Don't leak the token in the error message #317

merged 1 commit into from
Oct 14, 2024

Conversation

JasonGross
Copy link
Member

Should fix the issue at coq/coq#19680 (comment)

@JasonGross JasonGross mentioned this pull request Oct 13, 2024
Merged
Zimmi48
Zimmi48 approved these changes Oct 13, 2024
View reviewed changes
Copy link
Member

@Zimmi48 Zimmi48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, it would be good to introduce a more general mask to all our logging functions. I wonder if there is a library that could be used to do this.

This was referenced Oct 13, 2024
Merged
Open
@JasonGross JasonGross merged commit a1e0cc7 into coq:master Oct 14, 2024
@JasonGross JasonGross deleted the no-leak-token branch October 14, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zimmi48 Zimmi48 Zimmi48 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JasonGross @Zimmi48