-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Nix setup to rely on the Coq Nix Toolbox. #77
Conversation
53813e2
to
bc91aef
Compare
One general comment: this setup is completely opaque to anyone who doesn't know Nix and Cachix. With the previous setup, I could at least extrapolate what an option meant, but there is just no hope with stuff like |
"Bundle" isn't a Nix term but a toolbox-specific term. We tried to document it in the toolbox repository and in the templates PR. Basically, it describes a set of compatible package versions. But your comment isn't just about the |
I understand that with increased generality comes more files and options, but at the point where 3-4 options and 4+ files are needed for Nix CI, I think we should recommend smaller projects to go with Docker only. At least I think I will do that with my own private small projects. |
Well, until now the Nix setup was very limited and didn't stand the comparison with the Docker-Coq setup. It's becoming interesting only now. In particular, if you have dependencies that are not pre-built in one of the Docker images or if you want to easily test reverse dependencies. AAC-Tactics is not the best example to demonstrate that. |
Here is a new version of the PR, based on a lightweight toolbox-based setup. I've included a We need coq/coq#14723 to get Coq master commits to be properly pushed to the We will also need NixOS/nixpkgs#116690 to go back to using the |
First run took 13 minutes on GitHub Actions and 10 minutes on Travis CI (including Coq compilation). However, I cannot test the speed-up due to caching because this PR is open from a fork. I will reopen from a local branch to get access to the secret variable |
Use the dynamic workflow generation.
(Testing coq-community/templates#87.)