Conversation
Collaborator
|
@copilot I observe two of the tests during the These appear related to the changes. Please investigate and make necessary changes. Attached is the complete log for the |
…on bug in broadcast events The PR ports 24 upstream commits through 9a0a1a5 adding: - Protocol v3 with v2 backward compatibility - BYOK model listing (onListModels hook) - Agent pre-selection (SessionConfig.setAgent) - onEvent handler (registered before session.create RPC) - Register-before-RPC session insertion - 9 new broadcast event types (ExternalToolRequestedEvent, etc.) - CopilotSession.log() API Bug fix: when permission/tool broadcast handlers throw synchronously, catch blocks now send denial/error responses to unblock the CLI server. Without this fix, sendAndWait() would timeout waiting for SessionIdleEvent. Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions workflow for Java SDK tests
Fix: send denial/error response when broadcast permission/tool handler throws synchronously (ports upstream v3 sync)
Mar 10, 2026
Copilot stopped work on behalf of
edburns due to an error
March 10, 2026 16:36
Collaborator
|
Please try again to fix the errors I reported when running the "Build & Test" workflow. |
Collaborator
|
@copilot Please try again to fix the errors I reported when running the "Build & Test" workflow. |
…dAsync The v3 CLI (1.0.3-0) does not recognize "denied-could-not-request-from-user" as a valid permission result kind. Use the correct constant PermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USER which maps to "denied-no-approval-rule-and-could-not-request-from-user". This fixes the CI failures in: - PermissionsTest.testShouldHandlePermissionHandlerErrorsGracefully - ErrorHandlingTest.testShouldHandlePermissionHandlerErrorsGracefully_deniesPermission Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Contributor
Author
Fixed in commit
Fixed in commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…(ported from #185) Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CopilotSession.java)e592e47pushed tocopilot/sync-upstream-commits-againimport PermissionRequestResultKindPermissionRequestResultKind.DENIED_COULD_NOT_REQUEST_FROM_USERconstant (fixes CI failures)Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.