fix: skip excluded paths before rendering #1440
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed a bug related to skipping excluded files, which may even contain malformed Jinja syntax. Before, Copier determined whether a file is skipped after rendering it, which failed when the file contained malformed template syntax. Since the file should have been skipped, rendering should not have been attempted at all, so even malformed template syntax should not have mattered. Now, skipping excluded files happens before a rendering attempt, so even malformed template syntax in excluded files is allowed.
This problem came up in a slightly different scenario where
copier.yml
contained_envops
settings with Jinja statement markers,_templates_suffix: ""
, and no subdirectory was configured, so thatcopier.yml
was attempted to be rendered before the exclusion logic would have ignored it, which led to the reported problem in #1410. But it turned out that the root cause was more fundamental, which I've been able to fix with a simple change.Fixes #1410.