Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(typing): use Literal type hint for conflict attribute #1200

Conversation

sisp
Copy link
Member

@sisp sisp commented Jun 16, 2023

I've made the type hint for the conflict attribute more precise by using Literal["rej", "inline"] instead of str.

@yajo Is refactor(typing) the correct change type in your opinion? It seemed the most appropriate to me, but I couldn't find a guideline for committing only typing changes.

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #1200 (5d4d0fe) into master (1b351bc) will increase coverage by 0.17%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
+ Coverage   96.74%   96.92%   +0.17%     
==========================================
  Files          47       47              
  Lines        3935     3935              
==========================================
+ Hits         3807     3814       +7     
+ Misses        128      121       -7     
Flag Coverage Δ
unittests 96.92% <100.00%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
copier/main.py 95.64% <100.00%> (ø)

... and 2 files with indirect coverage changes

@yajo yajo merged commit 62bed4f into copier-org:master Jun 25, 2023
19 of 20 checks passed
@yajo
Copy link
Member

yajo commented Jun 25, 2023

I relabeled the commit to the build category. Refactor commits appear in the changelog, and I don't think this one deserves such a honor. 😜

@sisp sisp deleted the refactor/use-literal-type-hint-for-conflict-attribute branch June 25, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants