vine: make immediate recovery to recover immediately #4069
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
m.tune
parameterimmediate-recovery
was meant to immediately create recovery tasks when the only worker containing a temp file was lost. However, it was only activated for the input files of tasks currently running at the lost worker. This pr fixes that.The use case is workflows such as dynamic map reduce where temporary files are undeclared as soon as they are not needed anymore, and any declared file will be eventually used in the future. Since tasks are created dynamically, the management of files cannot be left to taskvine proper.
Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make test
Run local tests prior to pushing.make format
Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lint
Run lint on source code prior to pushing.