Vine: Fix Crash After Idle Disconnect #4065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify idle-disconnect to send "exit" message but not disconnect immediately. (let the worker do it)
dthain
added
bug
btovar
pushed a commit
that referenced
this pull request
Feb 26, 2025
* - Commentary on poll_active_workers to clarify purpose. - Modify idle-disconnect to send "exit" message but not disconnect immediately. (let the worker do it) * format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
@btovar observed a problem in which the manager crashes after processing an
idle-disconnectmessage and disconnecting the worker. The problem is that this invalidates thevine_worker_infoobject and thelinkobject in the middle ofhandle_worker. If theidle-disconnectis followed by any other asynchronous message (which is likely) then the manager ends up seeing messages from a worker that no longer exists.The solution here is to eliminate the special case:
handle_idle_disconnectnow sends anexitmessage to a worker, but does not disconnect it immediately. This allows the manager to process any following asynchronous messages, and the worker can perform whatever cleanup and communication it needs to do before disconnecting. And then the disconnect will be handled in the single (normal) place when the connection is dropped.@colinthomas-z80 the crash was occurring in the recently-modified location of
link_poll_active_workersbut really the problem was deeper in that we shouldn't be invalidating the worker object in multiple places.Merge Checklist
The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.
make testRun local tests prior to pushing.make formatFormat source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)make lintRun lint on source code prior to pushing.