vine: reserve a factor of disk when allocating resources

[JinZhou5042]

Proposed Changes

Part of #4006

Testing results using 32 4-core workers

• Before
  

• After
  

Merge Checklist

The following items must be completed before PRs can be merged.
Check these off to verify you have completed all steps.

• make test Run local tests prior to pushing.
• make format Format source code to comply with lint policies. Note that some lint errors can only be resolved manually (e.g., Python)
• make lint Run lint on source code prior to pushing.
• Manual Update: Update the manual to reflect user-visible changes.
• Type Labels: Select a github label for the type: bugfix, enhancement, etc.
• Product Labels: Select a github label for the product: TaskVine, Makeflow, etc.
• PR RTM: Mark your PR as ready to merge.

[JinZhou5042]

We are alomost there. @btovar, could you confirm if factoring the disk just before rmsummary_merge_max(limits, min); is the right way to do it?

Are the position and the condition on proportional resources correct?

......

if (q->proportional_resources) {
	limits->disk *= q->disk_proportion_available_to_task;
}

rmsummary_merge_max(limits, min);
rmsummary_merge_override_basic(limits, t->resources_requested);

return limits;

[btovar]

I think you want limits->disk *= q->disk_proportion_available_to_task; always, not only with proportional resources? The reasoning is that it is a policy for the cache?