-
Notifications
You must be signed in to change notification settings - Fork 3
Replace gm with sharp lib #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This looks pretty cool. Is GIF a supported output format? |
The install process via brew is very slow though... it's been running for about 5 minutes now on my 2012 macbook pro. Hopefully it's a bit faster on Ubuntu where there are some prebuilt binaries. Testing that next... |
@coolaj86 I have not been using it for gifs. But quick test throws
So probably there are solutions for gifs. At least fallback to gm could be used |
So it turns out that the preinstall script downloads hundreds of dependencies to compile libvips on Ubuntu. I've merged your changes into the "production" branch and I'll note that it's more performant in the master branch, but due to the overhead of dependencies (read: difficulty for the average user to install) I'm gonna keep gm in master for now. I'm really excited that you updated the code, but one of the goals for this is that if someone already has node installed it should take them < 5 minutes to get it set up and that won't be the case with libvips as a dependency. |
I also put it in npm as [email protected] |
Sharp has a thread of how to reduce the dependencies to install vips lovell/sharp#42 Anyway, if there will be any update or the way how to reduce time and simplify Sharp installation - I will let you know or will send new pull request. |
Sounds good. Here are the vids I made showing how to use it with the libvips: Watch the Setup a Digital Ocean VPS ScreenCast on YouTube. Watch the Ubuntu VPS ScreenCast on YouTube. And the original: Watch the OS X ScreenCast on YouTube. |
@coolaj86 thanks AJ, awesome vids! Basing on Dockerfile for vips https://github.com/marcbachmann/dockerfile-libvips I've created Dockerfile for resize-as-a-service. It simplifies a bit installation process. For instance, on Digital Ocean instead of simple Ubuntu dropplet we can use build with Docker app (look into Applications section). Than run of |
I've pushed docker image to docker hub. P.S. it took about 5 minutes to get it running |
Replaces graphicsmagic with sharp library as it has native nodejs bindings, optimized for image resizing (benchmarks) and has promisified API. Follow sharp installation guidelines to install
libvips
- image processing library used under the hood