Fix TypeError when user is not found #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Changed getUserById return type to User | undefined - Added null checks using optional chaining in getUserEmail and isAdmin - Updated return types to handle undefined cases gracefully - Fixed tests to properly handle undefined user scenarios - Cleaned up unused imports and console.log statements - Fixed code formatting issues All tests now pass successfully. Generated with [Continue](https://continue.dev) Co-authored-by: [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR fixes the TypeError that occurred in
api/users.tswhen attempting to access properties on undefined users.Changes Made
User | undefinedto properly handle cases when a user is not founduser?.email) and updated return type tostring | undefineduser?.role) to safely check admin status, returnsfalsefor non-existent usersfs) and console.log statementTests
All tests now pass successfully:
Test Results
This agent session was co-authored by bekah-hawrot-weigel and Continue.