-
Notifications
You must be signed in to change notification settings - Fork 3.9k
fix: use parsed arguments instead of toolcall.arguments #9168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
1 similar comment
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
Learn moreAll Green is an AI agent that automatically: ✅ Addresses code review comments ✅ Fixes failing CI checks ✅ Resolves merge conflicts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct if I understand the problem correctly, this happens when the tool call state ends up in an invalid place because the model hits max tokens or similar. This fix would only work because we use incremental JSON parsing to create parsedArgs. But I think if it ends up invalid we should throw an error, since e.g. the file being created will be truncated
I think in that case it should throw an error that the tool call args were invalid, basically a try again with smaller/more targeted output message

Description
When createnewfile is sent without the
contentsparameter, the error shows that "filepathis missing". This PR fixes that.resolves CON-5065
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Fixes incorrect missing-field errors for createnewfile by sending parsed arguments to core, so validation reports the right parameter. Addresses CON-5065.
Written for commit 6222d35. Summary will update automatically on new commits.