Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Dec 15, 2025

Description

When createnewfile is sent without the contents parameter, the error shows that "filepath is missing". This PR fixes that.

resolves CON-5065

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixes incorrect missing-field errors for createnewfile by sending parsed arguments to core, so validation reports the right parameter. Addresses CON-5065.

  • Bug Fixes
    • Use parsedArgs (JSON) for function.arguments in tools/call.
    • Missing-parameter errors now correctly point to contents instead of filepath.

Written for commit 6222d35. Summary will update automatically on new commits.

@continue
Copy link
Contributor

continue bot commented Dec 15, 2025

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

1 similar comment
@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@continue-development-app
Copy link

All Green - Keep your PRs mergeable

Learn more

All Green is an AI agent that automatically:

✅ Addresses code review comments

✅ Fixes failing CI checks

✅ Resolves merge conflicts

@uinstinct uinstinct marked this pull request as ready for review December 15, 2025 17:48
@uinstinct uinstinct requested a review from a team as a code owner December 15, 2025 17:48
@uinstinct uinstinct requested review from Patrick-Erichsen and removed request for a team December 15, 2025 17:48
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Dec 15, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct if I understand the problem correctly, this happens when the tool call state ends up in an invalid place because the model hits max tokens or similar. This fix would only work because we use incremental JSON parsing to create parsedArgs. But I think if it ends up invalid we should throw an error, since e.g. the file being created will be truncated

I think in that case it should throw an error that the tool call args were invalid, basically a try again with smaller/more targeted output message

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

2 participants