Skip to content

Conversation

@uinstinct
Copy link
Contributor

@uinstinct uinstinct commented Nov 20, 2025

Description

Reverts #6711

Do not add the full file when selection is empty. Only focus on the extension editor.

resolves CON-4936

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Reverts the change that added the full file when no text is selected. The extension now only adds the highlighted selection to context and skips related E2E tests, addressing CON-4936.

Written for commit 1bf2385. Summary will update automatically on new commits.

@uinstinct uinstinct requested a review from a team as a code owner November 20, 2025 16:18
@uinstinct uinstinct requested review from sestinj and removed request for a team November 20, 2025 16:18
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 20, 2025
@uinstinct uinstinct changed the title fix: revert add full file when selection is empty revert: add full file when selection is empty Nov 20, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Nov 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2025
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uinstinct looks like there are tests for this functionality which will need to be updated.

Also could we change the language from "reverts" to "related" or "reverts some behavior"? It's not a full reversion as that PR also added other thing like removing sidebar toggle etc.

CON-4936 also involves fixing CMD + Shift + L. Could we address that issue here as well?

@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Nov 20, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Nov 21, 2025
@uinstinct uinstinct requested a review from RomneyDa November 21, 2025 12:51
Copy link
Collaborator

@RomneyDa RomneyDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2025
@RomneyDa RomneyDa merged commit 0b7ff1f into continuedev:main Nov 21, 2025
55 of 57 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Issues and PRs Nov 21, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2025
@uinstinct uinstinct deleted the revert-add-full-file branch November 22, 2025 03:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants