-
Notifications
You must be signed in to change notification settings - Fork 3.8k
revert: add full file when selection is empty #8820
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@uinstinct looks like there are tests for this functionality which will need to be updated.
Also could we change the language from "reverts" to "related" or "reverts some behavior"? It's not a full reversion as that PR also added other thing like removing sidebar toggle etc.
CON-4936 also involves fixing CMD + Shift + L. Could we address that issue here as well?
RomneyDa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates!
Description
Reverts #6711
Do not add the full file when selection is empty. Only focus on the extension editor.
resolves CON-4936
AI Code Review
@continue-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Reverts the change that added the full file when no text is selected. The extension now only adds the highlighted selection to context and skips related E2E tests, addressing CON-4936.
Written for commit 1bf2385. Summary will update automatically on new commits.