feat: restore trimmed/whitespace search and replace fallbacks #7866

RomneyDa · 2025-09-20T00:50:59Z

Description

Jaro Winkler was removed here #7240
Other fallbacks were removed here #7267
This PR reintroduces whitespace and trimmed fallbacks

Other key changes

unifies search and replace logic between extensions and CLI
Removes ability to create a file with multi edit and empty old_string because it's confusing and pretty much fully separate functionality

Summary by cubic

Restores trimmed and whitespace-ignored find/replace fallbacks and fixes match indexing to make edits more reliable. Adds structured ContinueError reasons surfaced in CLI/GUI and telemetry, and consolidates find/replace logic in core with extensive tests.

New Features
- Restored trimmed and whitespace-ignored matching as fallbacks; corrected endIndex mapping for whitespace-ignored matches.
- Added findSearchMatches and performReplace helpers for single and multi-edit flows.
- Introduced ContinueError with reason codes; propagated through CLI/GUI and captured in PostHog (errorReason).
- Added comprehensive vitest coverage for matching strategies and edge cases.
Refactors
- Moved find/replace utils from GUI to core; updated imports across app.
- Removed experimental CLI search-and-replace tool and its parsers.
- Updated tools and file security checks to throw ContinueError (with specific reasons).
- Disabled Jaro-Winkler fuzzy strategy pending fix (left TODO).

…github.com/continuedev/continue into dallin/search-replace-fallbacks-v2

github-actions · 2025-09-20T00:52:07Z

AI Code Review

AI review failed due to service initialization issues. Please check the Continue API key and configuration.

No specific line comments generated.

💡 To request a new detailed review, comment @continue-detailed-review

cubic-dev-ai

9 issues found across 26 files

Prompt for AI agents (all 9 issues)


Understand the root cause of the following 9 issues and fix them.


<file name="gui/src/pages/gui/ToolCallDiv/FindAndReplace.test.tsx">

<violation number="1" location="gui/src/pages/gui/ToolCallDiv/FindAndReplace.test.tsx:46">
Import targets core module while tests still mock a different (now missing) path, so performFindAndReplace won’t be mocked and vi.importActual will fail.</violation>
</file>

<file name="core/edit/searchAndReplace/findSearchMatch.vitest.ts">

<violation number="1" location="core/edit/searchAndReplace/findSearchMatch.vitest.ts:204">
Test title contradicts assertion and implementation; rename to reflect emptySearch result instead of null.</violation>
</file>

<file name="gui/src/util/clientTools/callClientTool.ts">

<violation number="1" location="gui/src/util/clientTools/callClientTool.ts:64">
Unknown error case drops the original message, reducing debuggability; include String(e) when creating the ContinueError.</violation>
</file>

<file name="extensions/cli/src/telemetry/telemetryService.ts">

<violation number="1" location="extensions/cli/src/telemetry/telemetryService.ts:525">
PostHog events may be dropped on process exit; telemetryService.shutdown doesn’t call posthogService.shutdown to flush pending events.</violation>

<violation number="2" location="extensions/cli/src/telemetry/telemetryService.ts:525">
PostHog capture is gated by isEnabled() (OTLP metrics). Without OTLP config, this call never executes; if PostHog should send regardless, move it outside this gate.</violation>

<violation number="3" location="extensions/cli/src/telemetry/telemetryService.ts:525">
Async telemetry call is not awaited or explicitly marked fire-and-forget; prefix with void to make intent clear and avoid accidental unhandled promise usage.</violation>
</file>

<file name="gui/src/redux/thunks/callToolById.ts">

<violation number="1" location="gui/src/redux/thunks/callToolById.ts:142">
Telemetry schema change: replacing errorMessage with errorReason may break existing analytics consumers. Consider maintaining backward compatibility (e.g., include both fields or deprecate gradually).</violation>
</file>

<file name="core/edit/searchAndReplace/performReplace.ts">

<violation number="1" location="core/edit/searchAndReplace/performReplace.ts:31">
Comment says edits are applied in reverse order, but code applies them sequentially; update the comment for accuracy or implement reverse ordering.</violation>
</file>

<file name="core/util/errors.ts">

<violation number="1" location="core/util/errors.ts:19">
Set the error name in the constructor so logs and handlers see &#39;ContinueError&#39; instead of the generic &#39;Error&#39;.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

gui/src/pages/gui/ToolCallDiv/FindAndReplace.test.tsx

cubic-dev-ai · 2025-09-20T01:06:31Z

core/edit/searchAndReplace/findSearchMatch.vitest.ts

+      });
+    });
+
+    it("should return null for empty search content after whitespace removal", () => {


Test title contradicts assertion and implementation; rename to reflect emptySearch result instead of null.

Prompt for AI agents

Address the following comment on core/edit/searchAndReplace/findSearchMatch.vitest.ts at line 204: <comment>Test title contradicts assertion and implementation; rename to reflect emptySearch result instead of null.</comment> <file context> @@ -0,0 +1,571 @@ + }); + }); + + it("should return null for empty search content after whitespace removal", () => { + const fileContent = "some content"; + const searchContent = " \t\n "; </file context>

cubic-dev-ai · 2025-09-20T01:06:31Z

gui/src/util/clientTools/callClientTool.ts

+          ? e
+          : e instanceof Error
+            ? new ContinueError(ContinueErrorReason.Unspecified, e.message)
+            : new ContinueError(ContinueErrorReason.Unknown),


Unknown error case drops the original message, reducing debuggability; include String(e) when creating the ContinueError.

Prompt for AI agents

Address the following comment on gui/src/util/clientTools/callClientTool.ts at line 64: <comment>Unknown error case drops the original message, reducing debuggability; include String(e) when creating the ContinueError.</comment> <file context> @@ -51,18 +52,16 @@ export async function callClientTool( + ? e + : e instanceof Error + ? new ContinueError(ContinueErrorReason.Unspecified, e.message) + : new ContinueError(ContinueErrorReason.Unknown), output: undefined, }; </file context>

Suggested change

: new ContinueError(ContinueErrorReason.Unknown),

: new ContinueError(ContinueErrorReason.Unknown, String(e)),

cubic-dev-ai · 2025-09-20T01:06:32Z

extensions/cli/src/telemetry/telemetryService.ts

    // TODO: Implement OTLP logs export
    logger.debug("Tool result event", attributes);
+
+    posthogService.capture("cli_tool_call_outcome", {


PostHog events may be dropped on process exit; telemetryService.shutdown doesn’t call posthogService.shutdown to flush pending events.

Prompt for AI agents

Address the following comment on extensions/cli/src/telemetry/telemetryService.ts at line 525: <comment>PostHog events may be dropped on process exit; telemetryService.shutdown doesn’t call posthogService.shutdown to flush pending events.</comment> <file context> @@ -515,11 +518,17 @@ class TelemetryService { // TODO: Implement OTLP logs export logger.debug("Tool result event", attributes); + + posthogService.capture("cli_tool_call_outcome", { + succeeded: options.success, + toolName: options.toolName, </file context>

cubic-dev-ai · 2025-09-20T01:06:32Z

extensions/cli/src/telemetry/telemetryService.ts

    // TODO: Implement OTLP logs export
    logger.debug("Tool result event", attributes);
+
+    posthogService.capture("cli_tool_call_outcome", {


PostHog capture is gated by isEnabled() (OTLP metrics). Without OTLP config, this call never executes; if PostHog should send regardless, move it outside this gate.

Prompt for AI agents

Address the following comment on extensions/cli/src/telemetry/telemetryService.ts at line 525: <comment>PostHog capture is gated by isEnabled() (OTLP metrics). Without OTLP config, this call never executes; if PostHog should send regardless, move it outside this gate.</comment> <file context> @@ -515,11 +518,17 @@ class TelemetryService { // TODO: Implement OTLP logs export logger.debug("Tool result event", attributes); + + posthogService.capture("cli_tool_call_outcome", { + succeeded: options.success, + toolName: options.toolName, </file context>

✅ Addressed in c6858ad

cubic-dev-ai · 2025-09-20T01:06:32Z

gui/src/redux/thunks/callToolById.ts

+    succeeded: !error,
    toolName: toolCallState.toolCall.function.name,
-    errorMessage: errorMessage,
+    errorReason: error?.reason,


Telemetry schema change: replacing errorMessage with errorReason may break existing analytics consumers. Consider maintaining backward compatibility (e.g., include both fields or deprecate gradually).

Prompt for AI agents

Address the following comment on gui/src/redux/thunks/callToolById.ts at line 142: <comment>Telemetry schema change: replacing errorMessage with errorReason may break existing analytics consumers. Consider maintaining backward compatibility (e.g., include both fields or deprecate gradually).</comment> <file context> @@ -131,14 +137,14 @@ export const callToolById = createAsyncThunk< + succeeded: !error, toolName: toolCallState.toolCall.function.name, - errorMessage: errorMessage, + errorReason: error?.reason, duration_ms: duration_ms, }); </file context>

core/edit/searchAndReplace/performReplace.ts

extensions/cli/src/telemetry/telemetryService.ts

core/util/errors.ts

…allin/search-replace-fallbacks-v2

…allin/search-replace-error-codes-con-3928

…github.com/continuedev/continue into dallin/search-replace-fallbacks-v2

…allin/search-replace-fallbacks-v2

RomneyDa added 9 commits September 18, 2025 23:35

feat: continue error for better search and replace errors

5e60a13

fix: error name tweaks

3541eb9

feat: posthog telemetry for cli tool errors

77288b0

feat: find and replace fallbacks (restore)

5b5532f

WIP: perform search and replace with fallbacks

604ec09

fix: address cubic feedback

3b1227c

merge: main

3799964

Merge branch 'dallin/search-replace-error-codes-con-3928' of https://…

ffd3842

…github.com/continuedev/continue into dallin/search-replace-fallbacks-v2

fix: package lock

04c11d4

RomneyDa requested a review from a team as a code owner September 20, 2025 00:51

RomneyDa removed the request for review from a team September 20, 2025 00:51

github-project-automation bot added this to Issues and PRs Sep 20, 2025

RomneyDa requested a review from Patrick-Erichsen September 20, 2025 00:51

github-project-automation bot moved this to Todo in Issues and PRs Sep 20, 2025

dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Sep 20, 2025

fix: restore main package lock to cli

2baaa25

RomneyDa marked this pull request as draft September 20, 2025 00:54

cubic-dev-ai bot reviewed Sep 20, 2025

View reviewed changes

RomneyDa changed the title ~~feat: restore some search and replace fallbacks~~ feat: restore trimmed/whitespace search and replace fallbacks Sep 20, 2025

RomneyDa added 10 commits September 19, 2025 18:28

fix: broken test

fea8425

Merge branch 'main' of https://github.com/continuedev/continue into d…

cf4cad7

…allin/search-replace-fallbacks-v2

Merge branch 'main' of https://github.com/continuedev/continue into d…

b32ecaa

…allin/search-replace-error-codes-con-3928

fix: broken test

7527bde

fix: keep posthog and telemetry service separate

c6858ad

fix: lint

4e1cea9

fix: unify event names and fix tool calls test

0f94088

Merge branch 'dallin/search-replace-error-codes-con-3928' of https://…

c3cb302

…github.com/continuedev/continue into dallin/search-replace-fallbacks-v2

fix: cubic feedback

7716712

feat: refactor multiedit

b28ce70

RomneyDa added 2 commits September 20, 2025 01:15

feat: unify search and replace

c211ec8

Merge branch 'main' of https://github.com/continuedev/continue into d…

21aaa0c

…allin/search-replace-fallbacks-v2

RomneyDa closed this Sep 20, 2025

github-project-automation bot moved this from Todo to Done in Issues and PRs Sep 20, 2025

github-actions bot locked and limited conversation to collaborators Sep 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: restore trimmed/whitespace search and replace fallbacks #7866

feat: restore trimmed/whitespace search and replace fallbacks #7866

RomneyDa commented Sep 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Sep 20, 2025

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

Uh oh!

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

	: new ContinueError(ContinueErrorReason.Unknown),
	: new ContinueError(ContinueErrorReason.Unknown, String(e)),

feat: restore trimmed/whitespace search and replace fallbacks #7866

feat: restore trimmed/whitespace search and replace fallbacks #7866

Conversation

RomneyDa commented Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Summary by cubic

Uh oh!

github-actions bot commented Sep 20, 2025

AI Code Review

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-ai bot Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cubic-dev-ai bot Sep 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

RomneyDa commented Sep 20, 2025 •

edited

Loading

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading

cubic-dev-ai bot Sep 20, 2025 •

edited

Loading