feat: headless mode surface errors and exit code 1 #7864
+122
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tingwai
requested review from
Patrick-Erichsen
and removed request for
a team
dosubot
bot
added
the
size:L
tingwai
commented
Sep 19, 2025
| } | ||
| } | ||
|
|
||
| // Helper function to get streaming response based on compaction state |
There was a problem hiding this comment.
Lines 164-218 are not new, had to refactor out some code to satisfy eslint function complexity rule
AI Code ReviewAI review failed due to service initialization issues. Please check the Continue API key and configuration. No specific line comments generated. 💡 To request a new detailed review, comment |
tingwai
force-pushed
the
tingwai/con-3966-headless-exit-code
branch
from
ec2936c to
8ad3506
Compare
tingwai
force-pushed
the
tingwai/con-3966-headless-exit-code
branch
from
8ad3506 to
783760d
Compare
tingwai
commented
Sep 20, 2025
Comment on lines
+99
to
+103
| expect(result.exitCode).toBe(1); | ||
|
|
||
| // Should contain authentication error (not service initialization error) | ||
| expect(result.stderr).toContain("authentication_error"); | ||
| expect(result.stderr).toContain("invalid x-api-key"); |
There was a problem hiding this comment.
the config still succeeds in creating but now that we're surfacing errors test now exits with 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Artificially triggered a context length error to demonstrate error message and exit code:
AI Code Review
@continue-general-reviewor@continue-detailed-reviewChecklist
Screen recording or screenshot
[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]
Tests
[ What tests were added or updated to ensure the changes work as expected? ]
Summary by cubic
Headless CLI now surfaces errors as JSON on stdout and exits with code 1, making scripts reliable and detectable. Addresses CON-3966 by bubbling errors up instead of swallowing them.
New Features
Refactors