-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat: search and replace error codes #7848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
AI Code ReviewAI review failed due to service initialization issues. Please check the Continue API key and configuration. No specific line comments generated. 💡 To request a new detailed review, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3 issues found across 11 files
Prompt for AI agents (all 3 issues)
Understand the root cause of the following 3 issues and fix them.
<file name="gui/src/redux/thunks/callToolById.ts">
<violation number="1" location="gui/src/redux/thunks/callToolById.ts:102">
The error handling for core-side tools does not propagate the new structured `ContinueError`. The specific `reason` is lost when the error crosses the core-to-GUI boundary, as the transport layer appears to only handle string-based errors, making the error `reason` from core tools always `Unspecified` or lost entirely.</violation>
<violation number="2" location="gui/src/redux/thunks/callToolById.ts:102">
Core-side path sets error unconditionally, causing all core tool calls to be treated as failures even when no error occurred.</violation>
</file>
<file name="core/util/errors.ts">
<violation number="1" location="core/util/errors.ts:47">
Typo: enum member name "Unspecificied" should be "Unspecified".</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai
to give feedback, ask questions, or re-run the review.
…allin/search-replace-error-codes-con-3928
#7875 is built off of and includes this |
Description
More granular error codes for edit tools
Uses ContinueError type with ContinueErrorReason enum
Adds posthog telemetry for CLI tool errors
Also removed an unused error step container component
BREAKING CHANGE: changes posthog event names from
gui_tool_call_outcome
andgui_tool_call_decision
totool_call_outcome
andtool_call_decision
, respectivelySummary by cubic
Adds structured error codes for find-and-replace and multi-edit so tools return consistent, actionable errors. Improves validation, telemetry, and user feedback across CLI and GUI (CON-3928).
New Features
Refactors