Skip to content

Conversation

sestinj
Copy link
Contributor

@sestinj sestinj commented Sep 17, 2025

Description

Still needs work. The setup for placement strategies seems to be right, but the second strategy doesn't seem to function. 30min of debugging will probably do it, I'll hopefully get around to this soon.

AI Code Review

  • Team members only: AI review runs automatically when PR is opened or marked ready for review
  • Team members can also trigger a review by commenting @continue-general-review or @continue-detailed-review

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Keeps the Next Edit tooltip on-screen by choosing a nearby anchor line and horizontal padding that fit within the viewport. Introduces a pluggable placement strategy and sets a viewport-aware default.

  • New Features

    • Added NextEditPlacementStrategy with a ViewportAwarePlacementStrategy default.
    • Strategy picks an anchor line near the cursor (prefers visible lines) and computes padding to avoid horizontal overflow using editor.wordWrapColumn (fallback 100).
    • NextEditWindowManager now uses the strategy, clamps results, anchors at end-of-line, and converts padding to left margin.
  • Bug Fixes

    • Prevents the Next Edit tooltip from rendering off-screen and handles document churn by clamping line and padding.
    • GitHub workflow: added idempotency-key to review sessions to avoid duplicate runs.

Base automatically changed from nate/next-edit-ui-updates to main September 19, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Todo

Development

Successfully merging this pull request may close these issues.

1 participant