Skip to content

avoid garbled Chinese when call runTerminalCommandTool in windows #6599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xiaohuanxiong3
Copy link
Contributor

@xiaohuanxiong3 xiaohuanxiong3 commented Jul 13, 2025

Description

avoid garbled Chinese when call runTerminalCommandTool in windows

Checklist

  • [] I've read the contributing guide
  • [] The relevant docs, if any, have been updated or created
  • [] The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]


Summary by cubic

Fixed garbled Chinese output when running terminal commands on Windows by decoding output buffers with the correct encoding.

  • Dependencies
    • Added the iconv-lite package for encoding support.

@xiaohuanxiong3 xiaohuanxiong3 requested a review from a team as a code owner July 13, 2025 11:03
@xiaohuanxiong3 xiaohuanxiong3 requested review from tomasz-stefaniak and removed request for a team July 13, 2025 11:03
Copy link

netlify bot commented Jul 13, 2025

👷 Deploy request for continuedev pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 92b3bde

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jul 13, 2025
RomneyDa
RomneyDa previously approved these changes Jul 13, 2025
@github-project-automation github-project-automation bot moved this from Todo to In Progress in Issues and PRs Jul 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 13, 2025
@RomneyDa RomneyDa dismissed their stale review July 13, 2025 19:46

quick stamp no good, failing tests, to original reviewer @tomasz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants