Skip to content

chore: add ideInfo headers to hub reqs #6590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Patrick-Erichsen
Copy link
Collaborator

@Patrick-Erichsen Patrick-Erichsen commented Jul 12, 2025

Summary by cubic

Added IDE version and prerelease status headers to all hub requests to improve request tracking and diagnostics.

  • Dependencies
    • Updated internal and extension dependencies to latest patch versions.

@Patrick-Erichsen Patrick-Erichsen requested a review from a team as a code owner July 12, 2025 04:25
@Patrick-Erichsen Patrick-Erichsen requested review from RomneyDa and removed request for a team July 12, 2025 04:25
Copy link

netlify bot commented Jul 12, 2025

Deploy Preview for continuedev failed. Why did it fail? →

Name Link
🔨 Latest commit 72001f9
🔍 Latest deploy log https://app.netlify.com/projects/continuedev/deploys/6871e7980db5cf00097fa1ee

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jul 12, 2025
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic reviewed 10 files and found no issues. Review PR in cubic.dev.

@@ -86,7 +87,8 @@ class IntelliJIDE(
name = ideName,
version = ideVersion,
remoteName = remoteName,
extensionVersion = extensionVersion
extensionVersion = extensionVersion,
isPrerelease = false // TODO: Implement prerelease detection for JetBrains
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@exigow do you know of a way to determine the release channel of an installed extension?

Our versioning schema for JB doesn't have any context on whether a given version is an EAP or stable release, they're all just 1.0.X, so not sure if we have a way to determine this.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Patrick-Erichsen, AFAIK context like this is never added automatically.

I see two options:

  • We could add postfix like 1.0.0-eap when building the plugin. In the projects I worked on, this was exactly how we solved it.
  • We could add custom metadata to plugin.xml: we could read the channel like publishPlugin (from env vars) and add a custom tag like <channel> inside patchPluginXml. Then we could read this value from the code (I think it should be possible).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like option 1 of adding the -eap suffix. This would be helpful to make the release versions clearer in general imo.

I will make a Linear issue for this, but think it's okay to merge this in the meantime and just have the incorrect log info.

Copy link

⚠️ Conventional Commit Format

Your commit messages don't follow the conventional commit format, but this won't block your PR from being merged. We recommend downloading this extension if you are using VS Code.

Expected Format:

<type>[optional scope]: <description>

[optional body]

[optional footer(s)]

Examples:

  • feat: add changelog generation support
  • fix: resolve login redirect issue
  • docs: update README with new instructions
  • chore: update dependencies

Valid Types:

feat, fix, docs, style, refactor, perf, test, build, ci, chore, revert

This helps with:

  • 📝 Automatic changelog generation
  • 🚀 Automated semantic versioning
  • 📊 Better project history tracking

This is a non-blocking warning - your PR can still be merged without fixing this.

@RomneyDa
Copy link
Collaborator

@Patrick-Erichsen will wait on @exigow's input before reviewing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants