-
Notifications
You must be signed in to change notification settings - Fork 3.1k
chore: add ideInfo headers to hub reqs #6590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for continuedev failed. Why did it fail? →
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic reviewed 10 files and found no issues. Review PR in cubic.dev.
@@ -86,7 +87,8 @@ class IntelliJIDE( | |||
name = ideName, | |||
version = ideVersion, | |||
remoteName = remoteName, | |||
extensionVersion = extensionVersion | |||
extensionVersion = extensionVersion, | |||
isPrerelease = false // TODO: Implement prerelease detection for JetBrains |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exigow do you know of a way to determine the release channel of an installed extension?
Our versioning schema for JB doesn't have any context on whether a given version is an EAP or stable release, they're all just 1.0.X
, so not sure if we have a way to determine this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Patrick-Erichsen, AFAIK context like this is never added automatically.
I see two options:
- We could add postfix like
1.0.0-eap
when building the plugin. In the projects I worked on, this was exactly how we solved it. - We could add custom metadata to
plugin.xml
: we could read the channel likepublishPlugin
(from env vars) and add a custom tag like<channel>
insidepatchPluginXml
. Then we could read this value from the code (I think it should be possible).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like option 1 of adding the -eap
suffix. This would be helpful to make the release versions clearer in general imo.
I will make a Linear issue for this, but think it's okay to merge this in the meantime and just have the incorrect log info.
|
@Patrick-Erichsen will wait on @exigow's input before reviewing |
Summary by cubic
Added IDE version and prerelease status headers to all hub requests to improve request tracking and diagnostics.