Skip to content

fix(build): update esbuild to 0.25.3 #5344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chezsmithy
Copy link
Contributor

Description

I've noticed a build problem where the 2 year old version of esbuild is no longer pulling binaries which are required to build locally.

I'm noting a question that needs to be resolved:

https://github.com/chezsmithy/continue/blob/e96639f17107def6050f265508949d6a071a0222/extensions/vscode/scripts/prepackage.js#L386

Notes that it pulls a pre-build version of esbuild. Would this also need to be updated to use the latest version as well? I'm assuming so?

Checklist

  • The relevant docs, if any, have been updated or created
  • The relevant tests, if any, have been updated or created

Screenshots

[ For visual changes, include screenshots. Screen recordings are particularly helpful, and appreciated! ]

Testing instructions

[ For new or modified features, provide step-by-step testing instructions to validate the intended behavior of the change, including any relevant tests to run. ]

@chezsmithy chezsmithy requested a review from a team as a code owner April 24, 2025 23:53
@chezsmithy chezsmithy requested review from RomneyDa and removed request for a team April 24, 2025 23:53
Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for continuedev canceled.

Name Link
🔨 Latest commit e96639f
🔍 Latest deploy log https://app.netlify.com/sites/continuedev/deploys/680acee5cfd99b0008044e1f

@chezsmithy chezsmithy changed the title fix(build)-esbuild-version fix(build): update esbuild to 0.25.3 Apr 24, 2025
@Patrick-Erichsen
Copy link
Collaborator

@chezsmithy did you recently start having issues building? I'm wondering if this PR is the root cause: #5271

If so, can you try downgrading to Node 20.11.0 and see if it resolves the issue for you?

@Patrick-Erichsen Patrick-Erichsen requested review from Patrick-Erichsen and removed request for RomneyDa April 25, 2025 00:40
@Patrick-Erichsen
Copy link
Collaborator

Would this also need to be updated to use the latest version as well? I'm assuming so?

This is correct.

@chezsmithy - is this still an issue for you? I'd prefer to avoid bumping esbuild since we're planning to deprecate eventually, and it's quite sensitive logic.

@sestinj
Copy link
Contributor

sestinj commented Apr 29, 2025

+1 to the comments made here by Patrick—if at all possible we want to avoid this bump (we've bumped in the past and caused other bugs)

@chezsmithy
Copy link
Contributor Author

@Patrick-Erichsen This is fixed after doing some surgery on my node installation. I had some conflicts between node installed via homebrew and nvm. Removed all the homebrew versions and now things are fixed up. Made sure all the vscode tasks are running with the right node versions as well.

@chezsmithy chezsmithy closed this Apr 29, 2025
@chezsmithy chezsmithy deleted the fix-esbuild-version branch May 1, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants