[WIP] BREAKING CHANGE: full ESM support #2472
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axe312ger
force-pushed
the
refactor/full-esm-support
branch
from
0432433 to
c2e2a6b
Compare
11 tasks
axe312ger
changed the title
…s from last merge
…still should be resolved at some point
…g this api client
axe312ger
force-pushed
the
refactor/full-esm-support
branch
from
467d2d4 to
f0e17c2
Compare
axe312ger
commented
Jan 23, 2025
mgoudy91
reviewed
Feb 4, 2025
README.md
Outdated
There was a problem hiding this comment.
reminder to add migration.md + link from readme?
There was a problem hiding this comment.
This was referenced Feb 14, 2025
itxch
reviewed
Feb 26, 2025
| ".": { | ||
| "import": "./dist/esm/index.js", | ||
| "require": "./dist/contentful-management.cjs", | ||
| "types": "./dist/types/index.d.ts" |
There was a problem hiding this comment.
Types should be the first item in the exports btw, as per https://nodejs.org/api/packages.html#exports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR which will turn enable full ESM support for this package. Part of #2334.
Status: Pretty much finished. Reviews welcome!
The changes in this PR will be a BREAKING CHANGE and therefore we need to release it as new major version.
Anything that can be done before will be extracted and listed in #2334