HMS-5390: omit null values in upload response #953
Conversation
|
/retest |
|
/retest |
|
/retest |
|
null values in upload response is fixed and able to upload the chunk of rpm file |
|
ACK |
pkg/handler/repositories.go
Outdated
| ArtifactHref: utils.Ptr(""), | ||
| CompletedChecksums: make([]string, 0), |
There was a problem hiding this comment.
is there a reason for doing this rather than also adding the omitempty option, like for the created and last_updated?
I think that would result in cleaner API responses 😅
There was a problem hiding this comment.
yep you're right, it would be cleaner! the iqe test is checking the artifact_href, but i think we could instead check if this is in the response at all instead of checking it's empty. i'll push those changes up and verify the test changes we'll need
There was a problem hiding this comment.
pushed those up and @mayurilahane verified the changes in her upload test are working with this 🎉
There was a problem hiding this comment.
awesome, nice job 🎉 👏🏼
approved ✅
|
/retest |
Summary
created,last_updated,artifact_href, andcompleted_checksumsfrom the upload response (used when creating an upload or uploading a chunk). These values are not always needed and null values here prevent the generated IQE client from calling these APIsTesting steps