Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: move all secrets to github from codebuild #1003

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Test: move all secrets to github from codebuild #1003

merged 1 commit into from
Mar 6, 2025

Conversation

xbhouse
Copy link
Contributor

@xbhouse xbhouse commented Mar 3, 2025 •
edited
Loading

Summary

Switches secrets to be referenced from Github instead of Codebuild

Testing steps

  • PW tests pass (triggered manually on this branch and passed here)
  • No secrets being pulled from Codebuild (these look like $FOO instead of ${{ secrets.FOO }})

@xbhouse xbhouse marked this pull request as ready for review March 3, 2025 21:53
@marusak marusak requested a review from Andrewgdewar March 5, 2025 13:41
Andrewgdewar
Andrewgdewar approved these changes Mar 6, 2025
View reviewed changes
Copy link
Member

@Andrewgdewar Andrewgdewar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for this @xbhouse!

@Andrewgdewar Andrewgdewar merged commit e2492da into main Mar 6, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrewgdewar Andrewgdewar Andrewgdewar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xbhouse @Andrewgdewar