Skip to content
This repository was archived by the owner on Feb 10, 2021. It is now read-only.

Fix pypi deployment by using documentation at markdown format #37

Merged
merged 1 commit into from
Jul 4, 2019

Conversation

4383
Copy link
Collaborator

@4383 4383 commented Jun 29, 2019

podman README.md is markdown file who is used as a long description
so we need to specify to pypi to use markdown parser to properly
upload package

https://pypi.org/help/#description-content-type

@4383
Copy link
Collaborator Author

4383 commented Jun 29, 2019

Are you sure you fix the issue with #35 ?

The CI still fail on 0.0.2 and on a documentation format error

The pypi documentation tell us to use long_description_content_type="text/markdown"

@4383 4383 requested review from jwhonce and rhatdan June 29, 2019 10:49
@4383
Copy link
Collaborator Author

4383 commented Jun 29, 2019

Feel free to close this PR if it's already good for you

@rhatdan
Copy link
Member

rhatdan commented Jun 29, 2019

LGTM
@jwhonce PTAL

@4383
Copy link
Collaborator Author

4383 commented Jun 29, 2019

FYI, take care, it's a sort of rollback of the code before #35, but normally it's the right way to use README markdown format

@4383
Copy link
Collaborator Author

4383 commented Jun 29, 2019

we can test it by pushing a 0.0.3 and in a second time we need to update the README to explain how to install from pypi, I will submit a patch related to this, don't merge it until the deployment fail is not fixed.

@4383 4383 force-pushed the fix-md branch 5 times, most recently from bdad59b to 06bb1bb Compare July 1, 2019 10:37
@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

openstack have the same issue:

http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007459.html, I don't think that this is a podman issue...

Anyway these changes can be merged since they fix some nits and bad config names.

@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

According to this comment my local tests on python-podman seems ok:

$ twine check dist/*                                                                                                                      
Checking distribution dist/podman-0.0.3.dev1-py2.py3-none-any.whl: Passed
Checking distribution dist/podman-0.0.3.dev1.tar.gz: Passed

@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

I don't know why but on travis the same tests fails

@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

Locally I use:

$ pip list
Package           Version  
----------------- --------- 
pbr               5.3.1    
setuptools        41.0.1   
twine             1.13.0   
wheel             0.33.4   

and on travis:

  • setuptools 41.0.1
  • twine 1.13.0
  • wheel 0.33.4

The used packages are the sames and the check result is different...

@4383 4383 force-pushed the fix-md branch 2 times, most recently from cb774fd to b1e00c0 Compare July 1, 2019 13:32
@4383
Copy link
Collaborator Author

4383 commented Jul 1, 2019

#32 we already publish sdist and bdist_wheel but the deployment is stuck by a pypi recent updates who reintroduce some deactivated tests on the long_description format...

setup.cfg Outdated
@@ -20,6 +23,9 @@ keywords =
varlink
libpod
podman
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these keywords are producing an invalid PKG-INFO file, they look like this on Travis:

Keywords: varlink
libpod
podman

But should look like:

Keywords: varlink,libpod,podman

However I'm not sure where the bug lies.

Copy link
Collaborator Author

@4383 4383 Jul 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these keywords are producing an invalid PKG-INFO file, they look like this on Travis:

Keywords: varlink
libpod
podman

But should look like:

Keywords: varlink,libpod,podman

However I'm not sure where the bug lies.

@di Oh thanks, good catch!

I have already fixed this error on pbr but I need to verify why it still occur here.

I'll test with the inline syntaxe keywords: varlink, libpod, podman but I don't think it's an issue who can explain why twine check dist/* fail on travis.

@4383 4383 force-pushed the fix-md branch 2 times, most recently from 6e1c89f to 9af66d3 Compare July 3, 2019 08:19
@4383
Copy link
Collaborator Author

4383 commented Jul 3, 2019

Well it look like the issue is now fixed since I use the same commands that use pypa on their side to check that it work.

I think we can be confident with my proposed changes, and I think we can move forward by merging these changes and testing to deploy a release 0.0.3.

I want to keep the tests part (twine check dist/*) to ensure us that if we change things on README.md then we will detect potential markdown errors via the CI.

@di a greate thanks for all your help :)

In a second time I will inspect why pbr doesn't manage keywords in weird way even with my previous fix.

@4383
Copy link
Collaborator Author

4383 commented Jul 3, 2019

@jwhonce @rhatdan PTAL

podman README.md is markdown file who is used as a long description
so we need to specify to pypi to use markdown parser to properly
upload package

https://pypi.org/help/#description-content-type
@rhatdan
Copy link
Member

rhatdan commented Jul 4, 2019

LGTM

@rhatdan rhatdan merged commit 0e73bdb into containers:master Jul 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants