-
Notifications
You must be signed in to change notification settings - Fork 19
Fix pypi deployment by using documentation at markdown format #37
Conversation
Are you sure you fix the issue with #35 ? The CI still fail on 0.0.2 and on a documentation format error The pypi documentation tell us to use |
Feel free to close this PR if it's already good for you |
LGTM |
FYI, take care, it's a sort of rollback of the code before #35, but normally it's the right way to use README markdown format |
we can test it by pushing a |
bdad59b
to
06bb1bb
Compare
openstack have the same issue: http://lists.openstack.org/pipermail/openstack-discuss/2019-July/007459.html, I don't think that this is a podman issue... Anyway these changes can be merged since they fix some nits and bad config names. |
Well... I think the issue here is related to: |
According to this comment my local tests on python-podman seems ok: $ twine check dist/*
Checking distribution dist/podman-0.0.3.dev1-py2.py3-none-any.whl: Passed
Checking distribution dist/podman-0.0.3.dev1.tar.gz: Passed |
I don't know why but on |
Locally I use: $ pip list
Package Version
----------------- ---------
pbr 5.3.1
setuptools 41.0.1
twine 1.13.0
wheel 0.33.4 and on travis:
The used packages are the sames and the check result is different... |
cb774fd
to
b1e00c0
Compare
#32 we already publish sdist and bdist_wheel but the deployment is stuck by a pypi recent updates who reintroduce some deactivated tests on the |
6a0b780
to
8406d3c
Compare
setup.cfg
Outdated
@@ -20,6 +23,9 @@ keywords = | |||
varlink | |||
libpod | |||
podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these keywords are producing an invalid PKG-INFO file, they look like this on Travis:
Keywords: varlink
libpod
podman
But should look like:
Keywords: varlink,libpod,podman
However I'm not sure where the bug lies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these keywords are producing an invalid PKG-INFO file, they look like this on Travis:
Keywords: varlink libpod podman
But should look like:
Keywords: varlink,libpod,podman
However I'm not sure where the bug lies.
@di Oh thanks, good catch!
I have already fixed this error on pbr
but I need to verify why it still occur here.
I'll test with the inline syntaxe keywords: varlink, libpod, podman
but I don't think it's an issue who can explain why twine check dist/*
fail on travis.
6e1c89f
to
9af66d3
Compare
Well it look like the issue is now fixed since I use the same commands that use pypa on their side to check that it work. I think we can be confident with my proposed changes, and I think we can move forward by merging these changes and testing to deploy a release I want to keep the tests part ( @di a greate thanks for all your help :) In a second time I will inspect why |
podman README.md is markdown file who is used as a long description so we need to specify to pypi to use markdown parser to properly upload package https://pypi.org/help/#description-content-type
LGTM |
podman README.md is markdown file who is used as a long description
so we need to specify to pypi to use markdown parser to properly
upload package
https://pypi.org/help/#description-content-type