Skip to content

Conversation

@l0rd
Copy link
Member

@l0rd l0rd commented Nov 18, 2025

This PR is a follow-up of containers/netavark#1353 and removes references of iptables from the Podman source code:

  • Remove iptables enforcement on WSL*
  • Update test/upgrade to use nftables: CI runs upgrade from podman v5.6.2 (was 4.8.0) to current
  • Minor removals of various references to iptables in docs and tests

* This temporarily breaks rootful podman on amd64 WSL, but we have successfully tested the fix that should be released soon.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

Removed support for iptables

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l0rd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@l0rd l0rd marked this pull request as draft November 18, 2025 13:12
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2025
@packit-as-a-service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

matrix:
- env:
PODMAN_UPGRADE_FROM: v4.8.0
PODMAN_UPGRADE_FROM: v5.6.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point of the upgrade tests is to have a relative large delta as well.

What was the first podman image that has netavark with nftables support? We should tests that one as well in addition to 5.6.

Copy link
Member Author

@l0rd l0rd Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nftables support has been introduced in netavark v1.10.0 and the first podman image to include it is v4.9.0.

However the upgrade test from v4.9.0 is failing (podman network disconnect fails with Error removing subnet 10.88.0.0/16 from firewalld trusted zone: org.fedoraproject.FirewallD1.Exception: UNKNOWN_SOURCE: '10.88.0.0/16' is not in any zone).

The upgrade from v5.6.2 is failing too (in this case it's the output of podman images that doesn't match, probably because of a change in images order) and upgrade test from v5.5.0 fails for the same reason.

I am setting PODMAN_UPGRADE_FROM: v5.3.1 for now as this is the first version that works locally for me. I will open a separate issue for fixing/adding the test to upgrade from v5.6.2 to current.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However the upgrade test from v4.9.0 is failing (podman network disconnect fails with Error removing subnet 10.88.0.0/16 from firewalld trusted zone: org.fedoraproject.FirewallD1.Exception: UNKNOWN_SOURCE: '10.88.0.0/16' is not in any zone).

Weird, as a general rule we likely should not fail on removal if it doesn't exits, we should treat it as NOP. But yeah it is old enough that I don't think we need to test updating from that.

I am setting PODMAN_UPGRADE_FROM: v5.3.1 for now as this is the first version that works locally for me. I will open a separate issue for fixing/adding the test to upgrade from v5.6.2 to current.

SGTM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a change so that testing the upgrade from v5.6.2 works too. I have updated .cirrus.yml to run both v5.3.1 and v5.6.2 test cases.

Copy link
Member Author

@l0rd l0rd Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have opened containers/automation_images#427 to add the new images in the local registry (tests fail otherwise).

@l0rd l0rd marked this pull request as ready for review November 18, 2025 23:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 18, 2025
@l0rd l0rd marked this pull request as draft November 19, 2025 10:11
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 19, 2025
l0rd added a commit to l0rd/automation_images that referenced this pull request Nov 19, 2025
Add podman/stable v5.3.1 and v5.6.2 that are the new
versions tested in the upgrade test. This change is
required to merge
containers/podman#27555

Signed-off-by: Mario Loriedo <[email protected]>
l0rd added a commit to l0rd/podman-machine-os that referenced this pull request Nov 19, 2025
Podman 6.0 won't support iptables anymore. It's a
good opportunity to remove iptables from machine-os
too.

This is a follow-up of

containers/netavark#1353
containers/podman#27555

and related to

https://issues.redhat.com/browse/RUN-3723

Signed-off-by: Mario Loriedo <[email protected]>
l0rd added a commit to l0rd/containers-common that referenced this pull request Nov 19, 2025
l0rd added a commit to l0rd/container-libs that referenced this pull request Nov 19, 2025
@Luap99 Luap99 mentioned this pull request Nov 20, 2025
6 tasks
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall once the doc nit from Tom is fixed, if you rebase the CI images should pick up the new test images.

@mheon
Copy link
Member

mheon commented Nov 20, 2025

LGTM once the upgrade tests go green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. machine release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants