Skip to content

Conversation

@codynguyen-dev
Copy link
Contributor

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • [x ] Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

quadlet: `podman quadlet list` now supports a `.Pod` field in `--format` to display which pod a container quadlet belongs to

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. Please add a test for listing quadlets to this file: https://github.com/containers/podman/blob/main/test/system/253-podman-quadlet.bats

@TomSweeneyRedHat
Copy link
Member

Code LGTM
As @Honny1 noted, please add a test.

@codynguyen-dev
Copy link
Contributor Author

@Honny1 just pushed the test! let me know how it looks

Copy link
Member

@Honny1 Honny1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the new test. Overall, it looks good, but it fails. I added an explanation of where the problem is.

Comment on lines +534 to +535
assert "$output" =~ $'standalone.container[[:space:]]*$' "standalone container should have empty pod field"
assert "$output" =~ $'test-pod.pod[[:space:]]*$' "pod itself should have empty pod field"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test fails because $ matches the end of the entire $output string. If you want to match the end of the line, you need to use \n.

@mheon
Copy link
Member

mheon commented Nov 20, 2025

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codynguyen-dev, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
| .App | Name of application if Quadlet is part of an app |
| .Name | Name of the Quadlet file |
| .Path | Quadlet file path on disk |
| .Pod | Pod name (if the quadlet is part of a pod |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend changing to Pod name (if the quadlet is part of a pod - only applicable to .container files)

@mheon
Copy link
Member

mheon commented Nov 20, 2025

I have a documentation nit. Code LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants